chore(meshtls-rustls): Use aws-lc as the default crypto backend#4043
Merged
chore(meshtls-rustls): Use aws-lc as the default crypto backend#4043
aws-lc as the default crypto backend#4043Conversation
This changes the default crypto backend from ring to aws-lc-rs. Eventually we can remove ring entirely from the dependency tree, but for now this simply changes the default. Signed-off-by: Scott Fleener <scott@buoyant.io>
This adds the cross compilation toolchain and required environment variables to the release workflows and local Dockerfile. These will end up in the dev image, but for now we can specify them manually. Signed-off-by: Scott Fleener <scott@buoyant.io>
Signed-off-by: Scott Fleener <scott@buoyant.io>
Signed-off-by: Scott Fleener <scott@buoyant.io>
cratelyn
reviewed
Aug 5, 2025
| linkerd-io = { path = "../../io" } | ||
| linkerd-stack = { path = "../../stack" } | ||
| socket2 = "0.5" | ||
| socket2 = { version = "0.5", features = ["all"] } |
Member
There was a problem hiding this comment.
is this needed here? 🙇♀️ looking at the rest of this diff, i'm not sure if we need to alter our socket2 dependency.
Contributor
Author
There was a problem hiding this comment.
Best as I can figure, yes. I think the old backend was enabling this feature implicitly somewhere in the dep stack, and we rely on that feature being enabled even if we didn't declare it explicitly.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Member
|
i'm a huge fan of this change. breaking this out into (a) changing a default, followed by (b) removing alternative providers, seems like a great way to go about doing this. |
olix0r
reviewed
Aug 5, 2025
| linkerd-io = { path = "../../io" } | ||
| linkerd-stack = { path = "../../stack" } | ||
| socket2 = "0.5" | ||
| socket2 = { version = "0.5", features = ["all"] } |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
olix0r
approved these changes
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The broader ecosystem has mostly moved to
aws-lc-rsas the primaryrustlsbackend, and we should follow suit. This will also simplify the maintenance of the proxy's TLS implementation in the long term.This requires some extra configuration for successful cross-compilation, ideally we can remove this extra configuration once linkerd/dev v48 is available.
This doesn't remove
ringas a crypto backend, that can come in a follow-up at #4029