Skip to content

fix(policy): minor correctness fixes in outbound index #15157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
unleashed wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(policy): minor correctness fixes in outbound index #15157

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3411b9c
fix(policy): use safe port conversion in app_protocol mapping
unleashed Apr 7, 2026
a951dd7
fix(policy): correct expect messages in TLS and TCP route handlers
unleashed Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions policy-controller/k8s/index/src/outbound/index.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ impl kubert::index::IndexNamespacedResource<Service> for Index {
.filter_map(|port| {
port.app_protocol.as_ref().and_then(|p| {
Some((
NonZeroU16::new(port.port as u16)?,
port.port.try_into().ok().and_then(NonZeroU16::new)?,
AppProtocol::from_str(p.as_str()).expect("Infalliable"),
))
})
Expand Down Expand Up @@ -979,7 +979,7 @@ impl Namespace {
} else {
continue;
};
let route_namespace = route.namespace().expect("GrpcRoute must have a namespace");
let route_namespace = route.namespace().expect("TlsRoute must have a namespace");
let parent_namespace = parent_ref.namespace.as_ref().unwrap_or(&route_namespace);
if *parent_namespace != *self.namespace {
continue;
Expand Down Expand Up @@ -1078,7 +1078,7 @@ impl Namespace {
} else {
continue;
};
let route_namespace = route.namespace().expect("GrpcRoute must have a namespace");
let route_namespace = route.namespace().expect("TcpRoute must have a namespace");
let parent_namespace = parent_ref.namespace.as_ref().unwrap_or(&route_namespace);
if *parent_namespace != *self.namespace {
continue;
Expand Down
Loading