feat: add gateway.healthCheckNodePort Helm value#15174
Open
AldoFusterTurpin wants to merge 1 commit intolinkerd:mainfrom
Open
feat: add gateway.healthCheckNodePort Helm value#15174AldoFusterTurpin wants to merge 1 commit intolinkerd:mainfrom
AldoFusterTurpin wants to merge 1 commit intolinkerd:mainfrom
Conversation
AldoFusterTurpin
force-pushed
the
aldo/feat/healthCheckNodePort
branch
2 times, most recently
from
1b3099e to
7d4d57e
Compare
AldoFusterTurpin
force-pushed
the
aldo/feat/healthCheckNodePort
branch
from
bf02cfd to
de2773d
Compare
When externalTrafficPolicy is set to Local on the gateway service, Kubernetes auto-assigns a random healthCheckNodePort. This makes the port invisible, causes conflicts with other port controllers, and is inconsistent with the existing nodePort pinning support. Add an optional gateway.healthCheckNodePort value (and --gateway-healthcheck-nodeport CLI flag) following the same pattern as the existing gateway.nodePort and gateway.probe.nodePort. Fixes linkerd#15172 Signed-off-by: Aldo Fuster Turpin <aldo@timescale.com>
AldoFusterTurpin
force-pushed
the
aldo/feat/healthCheckNodePort
branch
from
02ad44b to
905eeb7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When externalTrafficPolicy is set to Local on the gateway service, Kubernetes auto-assigns a random healthCheckNodePort. This makes the port invisible, causes conflicts with other port controllers, and is inconsistent with the existing nodePort pinning support.
This PR adds an optional gateway.healthCheckNodePort value (and --gateway-healthcheck-nodeport CLI flag) following the same pattern as the existing gateway.nodePort and gateway.probe.nodePort.
Following TEST.md, I run
to generate the contents of multicluster/cmd/testdata/install_healthcheck_nodeport.golden and ensure the code does what it should do.
I deliberately don't check serviceExternalTrafficPolicy=Local in the template, because:
Fixes #15172
References: