refactor: STORIF-335 - Object storage drawers refactored.#13540
Open
dchyrva-akamai wants to merge 9 commits intolinode:developfrom
Open
refactor: STORIF-335 - Object storage drawers refactored.#13540dchyrva-akamai wants to merge 9 commits intolinode:developfrom
dchyrva-akamai wants to merge 9 commits intolinode:developfrom
Conversation
dchyrva-akamai
force-pushed
the
feature/STORIF-335
branch
from
2eede5f to
66e16e7
Compare
dchyrva-akamai
force-pushed
the
feature/STORIF-335
branch
3 times, most recently
from
84ab992 to
998134e
Compare
skulpok-akamai
approved these changes
Mar 27, 2026
dchyrva-akamai
requested review from
jdamore-linode
and removed request for
a team
dchyrva-akamai
force-pushed
the
feature/STORIF-335
branch
from
b41d27d to
6588e54
Compare
dchyrva-akamai
force-pushed
the
feature/STORIF-335
branch
5 times, most recently
from
020ba3e to
81a0ade
Compare
dwiley-akamai
approved these changes
Apr 14, 2026
Contributor
dwiley-akamai
left a comment
dwiley-akamai
left a comment
There was a problem hiding this comment.
Verification steps ✅
Code review ✅
Approved pending addition of manager changeset
Contributor
There was a problem hiding this comment.
Let's rename the pertinent files accordingly to remove OMC_ as well
Contributor
There was a problem hiding this comment.
It was renamed in the original PR, but I asked to rename it back to make the changes in the component more apparent - we planned to change this in a separate PR, but I guess we could change it right away.
Contributor
There was a problem hiding this comment.
This should be moved to src/hooks
Contributor
Author
There was a problem hiding this comment.
Thank you for you comment, this hook will only be used inside the ObjectStorage, I think it would be better to keep it closer, inside the feature folder int order to avoid future misuse.
dchyrva-akamai
force-pushed
the
feature/STORIF-335
branch
from
81a0ade to
7c35606
Compare
dchyrva-akamai
force-pushed
the
feature/STORIF-335
branch
from
7c35606 to
be47b76
Compare
Cloud Manager UI test results🔺 2 failing tests on test run #17 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/objectStorage/access-key.e2e.spec.ts,cypress/e2e/core/objectStorage/object-storage.e2e.spec.ts" |
||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Refactored object storage drawers to be standalone components and use browser navigation.
Changes 🔄
How to test 🧪
pnpm dev./object-storage/buckets./object-storage/access-keys.Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅