upcoming: [AISI-22] - Serverless Inference Sidebar Item In Cloud Manager#13580
Open
ChrisThomasAk wants to merge 2 commits intolinode:developfrom
Open
Conversation
Addition of a new top-level AI feature in navigation to the CM Navbar (PrimaryNav.tsx), aim overall is to create a base for first release of Serverless Inference features within CM, under the AI top level PrimaryNav.tsx : Added AI top level nav, and sub item > Serverless Inference. Also added required NavEntity & ProductFamily entries etc ai.svg: Added provisional AI icon for use in PrimaryNav.tsx ServerlessInference.tsx: Added default Nav location for Serverless Inference. It provides a Landing page for the feature and Tabs to navigate to the other 3 pages. It defaults to routing to Inference Hub InferenceHub.tsx: Added stub for Main landing page for Serverless Inference ModelLibrary.tsx: Added stub for Model Library, where customers can browse AI Models to Inference. ModelPlayground.tsx: Added stub for Model Playground, where customers can try/test models. ApiKeyManagement.tsx: Added stub for Api Key Management, where customers can manage their Inference API Keys Added isServerlessInferenceEnabled feature flag Put Serverless Inference entry in PrimaryNav.tsx behind isServerlessInferenceEnabled flag, feature is hidden by default Put routing to ServerlessInference behind isServerlessInferenceEnabled flag in ServerlessInferenceRoute.tsx. Without access, "Not Found: Page does not exist" notice is shown.
…to-Serverless-Inference
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Addition of a new top-level AI feature in navigation to the CM Navbar. Overall aim is to create a base for first release (FWP) of Serverless Inference features within CM
Changes 🔄
Scope 🚢
This release is intended to be internal only. It will be made available to dev/design team members via feature flag
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
immediately into dev environment - We will be building on this code with the feature pages for each of the 4 tabs it provides. Our initial internal build for this (FWP) is required by May. Final version of product is intended for November.
Preview 📷
This shows CM with the AI feature hidden by a feature flag check in PrimaryNav.tsx (line 269) and another in ServerlessInferenceRoute.tsx (lines 12-24) which blocks direct navigation to those URLS
I have shown the Sidebar nav enabled here, by commenting out its check. The route block is in place, so sub-urls will not be shown
The feature as it will appear with the feature flag isServerlessInferenceEnabled set as true
How to test 🧪
To view the Navbar, Serverless Inference and tabs, either
Prerequisites
Currently no test setup, this will follow
Reproduction steps
NA
Verification steps
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅