Skip to content

upcoming: [AISI-22] - Serverless Inference Sidebar Item In Cloud Manager#13580

Open
ChrisThomasAk wants to merge 2 commits intolinode:developfrom
ChrisThomasAk:upcomming-AISI-22-Allow-user-to-navigate-to-Serverless-Inference
Open

upcoming: [AISI-22] - Serverless Inference Sidebar Item In Cloud Manager#13580
ChrisThomasAk wants to merge 2 commits intolinode:developfrom
ChrisThomasAk:upcomming-AISI-22-Allow-user-to-navigate-to-Serverless-Inference

Conversation

@ChrisThomasAk
Copy link
Copy Markdown

Description 📝

Addition of a new top-level AI feature in navigation to the CM Navbar. Overall aim is to create a base for first release (FWP) of Serverless Inference features within CM

Changes 🔄

  • PrimaryNav.tsx: Added top level 'AI' feature, and inside it 'Serverless Inference' feature
  • ai.svg: A new entityIcon for the AI for the new AI features
  • ServerlessInferenceRoute.tsx: Added route for Serverless Inference
  • serverlessInferenceLazyRoute.ts: Lazy route for Serverless Inference
  • packages/manager/src/routes/index.tsx: Adds routes for Serverless Inference
  • packages/manager/src/routes/serverlessInference/index.ts: Adds routes for Serverless Inference
  • ServerlessInference.tsx: The default nav location for Serverless Inference. It provides a Landing page for the feature and Tabs to navigate to 3 other pages. It defaults to routing to 'Inference Hub' tab
  • InferenceHub.tsx: Added stub for Main landing page for Serverless Inference
  • ModelLibrary.tsx: Added stub for Model Library, where customers can browse AI Models to Inference.
  • ModelPlayground.tsx: Added stub for Model Playground, where customers can try/test models.
  • ApiKeyManagement.tsx: Added stub for Api Key Management, where customers can manage their Inference API Keys
  • serverHandlers.ts: Added changes for for mock code
  • /manager/src/features/ServerlessInference/utils.ts: Sets up isServerlessInferenceEnabled feature flag

Scope 🚢

This release is intended to be internal only. It will be made available to dev/design team members via feature flag

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Target release date 🗓️

immediately into dev environment - We will be building on this code with the feature pages for each of the 4 tabs it provides. Our initial internal build for this (FWP) is required by May. Final version of product is intended for November.

Preview 📷

AI-FeatureHiddenByFlags
This shows CM with the AI feature hidden by a feature flag check in PrimaryNav.tsx (line 269) and another in ServerlessInferenceRoute.tsx (lines 12-24) which blocks direct navigation to those URLS

AI-Feature-RoutesBlocked
I have shown the Sidebar nav enabled here, by commenting out its check. The route block is in place, so sub-urls will not be shown

AI-Feature-Displayed
The feature as it will appear with the feature flag isServerlessInferenceEnabled set as true

How to test 🧪

To view the Navbar, Serverless Inference and tabs, either

  • Comment out line 269 in PrimaryNav.tsx to see Sidebar nav entry
  • Comment out lines 12-24 in ServerlessInferenceRoute.tsx to allow nav to Serverless Inference + its tabs
  • Or enable isServerlessInferenceEnabled in your test environment

Prerequisites

Currently no test setup, this will follow

Reproduction steps

NA

Verification steps

  • Enabled isServerlessInferenceEnabled flag, should allow the feature to be visible
  • Comment out line 269 in PrimaryNav.tsx to see Sidebar nav entry
  • Comment out lines 12-24 in ServerlessInferenceRoute.tsx to allow nav to Serverless Inference + its tabs
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

Addition of a new top-level AI feature in navigation to the CM Navbar (PrimaryNav.tsx), aim overall is to create a base for first release of Serverless Inference features within CM, under the AI top level
PrimaryNav.tsx : Added AI top level nav, and sub item > Serverless Inference. Also added required NavEntity & ProductFamily entries etc
ai.svg: Added provisional AI icon for use in PrimaryNav.tsx

ServerlessInference.tsx: Added default Nav location for Serverless Inference. It provides a Landing page for the feature and Tabs to navigate to the other 3 pages. It defaults to routing to Inference Hub

InferenceHub.tsx: Added stub for Main landing page for Serverless Inference
ModelLibrary.tsx: Added stub for Model Library, where customers can browse AI Models to Inference.
ModelPlayground.tsx: Added stub for Model Playground, where customers can try/test models.
ApiKeyManagement.tsx: Added stub for Api Key Management, where customers can manage their Inference API Keys

Added isServerlessInferenceEnabled feature flag
Put Serverless Inference entry in PrimaryNav.tsx behind isServerlessInferenceEnabled flag, feature is hidden by default
Put routing to ServerlessInference behind isServerlessInferenceEnabled flag in ServerlessInferenceRoute.tsx. Without access, "Not Found: Page does not exist" notice is shown.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Review

Development

Successfully merging this pull request may close these issues.

2 participants