Skip to content

[PW_SID:1094939] [1/2] riscv: kvm: return SBI_ERR_FAILURE for pmu_snapshot_set_shmem OOM #1940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
linux-riscv-bot wants to merge 2 commits into
base: workflow__riscv__fixes
Choose a base branch
from
Open

[PW_SID:1094939] [1/2] riscv: kvm: return SBI_ERR_FAILURE for pmu_snapshot_set_shmem OOM #1940

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
613402c
riscv: kvm: return SBI_ERR_FAILURE for pmu_snapshot_set_shmem OOM
osamakader May 14, 2026
a843f67
riscv: kvm: return SBI_ERR_FAILURE for pmu_event_info OOM
osamakader May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions arch/riscv/kvm/vcpu_pmu.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,8 +453,10 @@ int kvm_riscv_vcpu_pmu_snapshot_set_shmem(struct kvm_vcpu *vcpu, unsigned long s
}

kvpmu->sdata = kzalloc(snapshot_area_size, GFP_ATOMIC);
if (!kvpmu->sdata)
return -ENOMEM;
if (!kvpmu->sdata) {
sbiret = SBI_ERR_FAILURE;
goto out;
}

/* No need to check writable slot explicitly as kvm_vcpu_write_guest does it internally */
if (kvm_vcpu_write_guest(vcpu, saddr, kvpmu->sdata, snapshot_area_size)) {
Expand Down Expand Up @@ -499,8 +501,10 @@ int kvm_riscv_vcpu_pmu_event_info(struct kvm_vcpu *vcpu, unsigned long saddr_low
}

einfo = kzalloc(shmem_size, GFP_KERNEL);
if (!einfo)
return -ENOMEM;
if (!einfo) {
ret = SBI_ERR_FAILURE;
goto out;
}

ret = kvm_vcpu_read_guest(vcpu, shmem, einfo, shmem_size);
if (ret) {
Expand Down