fel: add progress bar support for uboot command#233
Open
gworkman wants to merge 1 commit intolinux-sunxi:masterfrom
Open
fel: add progress bar support for uboot command#233gworkman wants to merge 1 commit intolinux-sunxi:masterfrom
gworkman wants to merge 1 commit intolinux-sunxi:masterfrom
Conversation
The sunxi-fel uboot (and spl) commands lacked the ability to show a progress bar when uploading the payload, unlike the write command. Support the -p / --progress flag by passing a progress callback through aw_fel_process_spl_and_uboot to aw_fel_write_uboot_image, which then sets up the progress indicator before calling aw_write_buffer.
Contributor
|
Is there any particular need for that? I see that's somewhat inconsistent with the other transfer commands, but as your screenshot above shows, U-Boot typically uploads within one second, so I am not sure we really need a progress bar? The moment you look at it, it's typically finished already. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sunxi-fel uboot (and spl) commands lacked the ability to show a progress bar when uploading the payload, unlike the write command.
Support the -p / --progress flag by passing a progress callback through aw_fel_process_spl_and_uboot to aw_fel_write_uboot_image, which then sets up the progress indicator before calling aw_write_buffer.
Result: