Skip to content

fel: add progress bar support for uboot command#233

Open
gworkman wants to merge 1 commit intolinux-sunxi:masterfrom
gworkman:master
Open

fel: add progress bar support for uboot command#233
gworkman wants to merge 1 commit intolinux-sunxi:masterfrom
gworkman:master

Conversation

@gworkman
Copy link
Copy Markdown

The sunxi-fel uboot (and spl) commands lacked the ability to show a progress bar when uploading the payload, unlike the write command.

Support the -p / --progress flag by passing a progress callback through aw_fel_process_spl_and_uboot to aw_fel_write_uboot_image, which then sets up the progress indicator before calling aw_write_buffer.

Result:

$ sunxi-fel -p uboot path/to/u-boot-loader.bin
100% [================================================]   535 kB,  450.4 kB/s

The sunxi-fel uboot (and spl) commands lacked the ability to show a
progress bar when uploading the payload, unlike the write command.

Support the -p / --progress flag by passing a progress callback through
aw_fel_process_spl_and_uboot to aw_fel_write_uboot_image, which then
sets up the progress indicator before calling aw_write_buffer.
@apritzel
Copy link
Copy Markdown
Contributor

Is there any particular need for that? I see that's somewhat inconsistent with the other transfer commands, but as your screenshot above shows, U-Boot typically uploads within one second, so I am not sure we really need a progress bar? The moment you look at it, it's typically finished already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants