feat: Add Votium initiative - #133
Conversation
1b3a0b0 to
dd8f10d
Compare
| } | ||
|
|
||
| function _depositIntoVotium() internal { | ||
| uint256 total = bold.balanceOf(address(this)); |
There was a problem hiding this comment.
As this contract inherits BribeInitiative, it automatically allows anyone to deposit BOLD bribes. When someone does that, those BOLD bribes show up on the UI, which might entice users to vote on the initiative. However, they won't be able to claim the bribes they earn, as this function is effectively stealing the bribes from them and giving it to LPs.
See the test test_Counterexample_BribeInsolvency that demonstrates this.
danielattilasimon
left a comment
danielattilasimon
left a comment
There was a problem hiding this comment.
We should either disable the BOLD bribes functionality of BribeInitiative (e.g. by overriding depositBribe and ensuring _boldAmount == 0) or do proper accounting to avoid commingling BOLD incentives (coming from Governance) with BOLD bribes.
See: #133 (comment) It reintroduces the issue of BOLD being potentially stuck in the contract, which is not a big deal anyway.
danielattilasimon
left a comment
danielattilasimon
left a comment
There was a problem hiding this comment.
Looks good to me! 👍 👍
2 participants
TODO