Skip to content

use ES6 export, export all directives as default export, add default export test#22

Open
Saeris wants to merge 4 commits into
lirown:masterfrom
Saeris:export-all-directives
Open

use ES6 export, export all directives as default export, add default export test#22
Saeris wants to merge 4 commits into
lirown:masterfrom
Saeris:export-all-directives

Conversation

@Saeris

@Saeris Saeris commented Aug 24, 2018

Copy link
Copy Markdown

Updated all files (except for src/directiveLocation) to use ES6 export syntax.

Changed the default export for the library to be an array of all directives to streamline usage in situations where a user wants to use all of the directives provided by the library.

Added a new test to ensure the default export is an array containing only instances of GraphQLDirective.

Updated README examples with new usage.

…export tests

Updated all files (except for src/directiveLocation) to use ES6 export syntax.

Changed the default export for the library to be an array of all directives to streamline usage in situations where a user wants to use all of the directives provided by the library.

Added a new test to ensure the default export is an array containing only instances of GraphQLDirective.

Updated README examples with new usage.
@coveralls

coveralls commented Aug 24, 2018

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling 8d6ba5a on Saeris:export-all-directives into 8ad5e70 on lirown:master.

@Saeris Saeris changed the title use ES6 export, export all directives as default export, add default export tests use ES6 export, export all directives as default export, add default export test Aug 24, 2018
@lirown

lirown commented Oct 24, 2018

Copy link
Copy Markdown
Owner

conflicts?

@Saeris

Saeris commented Oct 24, 2018

Copy link
Copy Markdown
Author

Conflicts should be resolved

Comment thread package.json
},
"homepage": "https://github.com/lirown/graphql-custom-directives#readme",
"dependencies": {
"lodash": "^4.17.5",

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why Lodash dependency twice?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants