Proposal: WIP: fullscreen cell and output

[cocoa-xu]

It would be nice if we could fullscreen cell and output. Although I haven't quite figured out a way to move/display these iframes in the output (and input if it's a smartcell) in the fullscreen view.

[josevalim]

Hi @cocoa-xu! You can already amplify outputs. Is that not enough? Do you have a use case where full screen is necessary?

[github-actions]

Uffizzi Preview deployment-56725 was deleted.

[cocoa-xu]

Hi @cocoa-xu! You can already amplify outputs. Is that not enough? Do you have a use case where full screen is necessary?

I think it can open new possibilities for livebook, for example, using Kino to do Keynote in fullscreen mode (like 1, 2), and one step further, that would be creating simple fullscreen apps with Kino (or other smart cells).

[josevalim]

Given this is specific to some use cases, perhaps the Kino should be the one allow to go full screen instead? Maybe if we add some permissions to the iframe that would be enough?

[cocoa-xu]

Given this is specific to some use cases, perhaps the Kino should be the one allow to go full screen instead? Maybe if we add some permissions to the iframe that would be enough?

Yeah for use cases like this I totally agree it would be the libraries' responsibility to do it.

Yet sometimes I feel the more or less the same way as @madlep mentioned in #2588, that occasionally there's a need make use of the screen real estate more effectively.

And of course, this PR is far from perfect, maybe I should switch it into an issue or we can just track it in #2588. I'll close this one ;)

[jonatanklosko]

We already allow iframes to enter fullscreen (#1982). It wouldn't work for kinos composed of frame/grid. Though in the slides example, the slides are specified using HTML, so it could as well be a single Kino.JS with a fullscreen action.

[hugobarauna]

It wouldn't work for kinos composed of frame/grid

@jonatanklosko Out of curiosity, why would it not work for kinos composed of frame/grid?

[jonatanklosko]

why would it not work for kinos composed of frame/grid?

The fullscreen mode is something an iframe can request, so it could be done with JavaScript from within Kino.JS. Frame and grid are built-in outputs and don't use iframes.