fix(phonic): Add preserveFunctionCallHistory flag to AgentTasks and use this function call history in Phonic plugin resets#1285
Open
qionghuang6 wants to merge 8 commits intolivekit:mainfrom
Conversation
buildTurnHistory previously only serialized text messages, dropping tool calls and their outputs from the system prompt sent on mid-session reset. Agents handed off mid-session lost access to any state that only existed in tool return values. Unify both history-building sites (pre-config postfix and reset) on a shared chatItemToText helper emitting simple XML-ish tags. Tool outputs are sliced to 16k chars to bound size.
🦋 Changeset detectedLatest commit: 9947220 The changes in this PR will be included in the next version bump. This PR includes changesets to release 26 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
qionghuang6
changed the title
preserveFunctionCallHistory flag to AgentTasks and use this function call history in Phonic plugin resets
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We noticed that for Task Groups in typescript, the mergedChatCtx has excludeFunctionCall: true , which could cause the next agent to not realize a tool has already been called when transitioning between tasks. It seems that for the Python SDK, there is a preserve_function_call_history flag.
We would like to add it here and use it in our plugin as well.
buildTurnHistorypreviously only serialized text messages, dropping tool calls and their outputs from the system prompt sent on mid-session reset. This PR includes the tool calls and changes the format of the turn history to XML.demo video:
https://screen.studio/share/58lb9tb4
Pre-Review Checklist
Testing
restaurant_agent.tsandrealtime_agent.tswork properly (for major changes)Additional Notes
Note to reviewers: Please ensure the pre-review checklist is completed before starting your review.