fix(deepgram): avoid double-encoding STT query params#1295
Open
Raysharr wants to merge 2 commits intolivekit:mainfrom
Open
fix(deepgram): avoid double-encoding STT query params#1295Raysharr wants to merge 2 commits intolivekit:mainfrom
Raysharr wants to merge 2 commits intolivekit:mainfrom
Conversation
🦋 Changeset detectedLatest commit: c82d8f8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 26 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
keytermandkeywords, including non-ASCII valuesDescription
The Deepgram STT websocket URL currently turns
keytermandkeywordsvalues into percent-escaped strings before they are added to the query string.URLSearchParamsalready performs query encoding, so these values end up encoded twice.That means Deepgram can receive values like
s%C5%82uchaminstead ofsłucham. The request still succeeds, but keyword prompting silently stops working for languages that rely on diacritics. The same issue also affects boostedkeywordsentries.Why this matters
keytermprompting for languages such as Polish, Czech, German, Spanish, and Portuguesekeywordsboosts when the values include non-ASCII text or:separatorsTesting
keytermvalues and boostedkeywordspnpm vitest run plugins/deepgram/src/_utils.test.ts