Fix stale playout state across multi-step voice turns#5533
Open
jayeshp19 wants to merge 2 commits intolivekit:mainfrom
Open
Fix stale playout state across multi-step voice turns#5533jayeshp19 wants to merge 2 commits intolivekit:mainfrom
jayeshp19 wants to merge 2 commits intolivekit:mainfrom
Conversation
efc3ae3 to
efcb35c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change makes interruption handling depend on whether the current generation is actively in playout, instead of only checking for the presence of a current
SpeechHandle.Changes
_advance_step()AgentActivityVerification
uv run ruff check tests/test_agent_session.pyuv run pytest tests/test_agent_session.py -k 'advance_step_resets_playout_state or interrupt_by_audio_activity' -quv run pytest tests/test_agent_session.py::test_interruption_before_speaking tests/test_agent_session.py::test_interruption tests/test_agent_session.py::test_tool_call -q