DOMPatch - #2
Draft
carson-katri wants to merge 3 commits into
Draft
Conversation
carson-katri
commented
Jun 24, 2025
| end) | ||
| end | ||
|
|
||
| # def morphdom(from_node, to_node, opts \\ []) do |
Member
Author
There was a problem hiding this comment.
This commented out section is an implementation I had started on that was more of a clone of the JS, but I abandoned it to get something working in a more functional style.
bcardarella
reviewed
Jun 25, 2025
| %{ node_type: @text_node, whole_text: from_whole_text } = from_child, | ||
| %{ node_type: @text_node, whole_text: to_whole_text } = _to_child | ||
| }, acc when from_whole_text != to_whole_text -> # text changed | ||
| GenDOM.Node.put(from_child, :whole_text, to_whole_text) |
Contributor
There was a problem hiding this comment.
try GenDOM.Node.put! I added that alternate form last week and it does a GenServer.cast instead of GenServer.call internally. This way you can update the state but avoid the blocking function call
bcardarella
reviewed
Jun 25, 2025
| on_before_node_discarded.(from_child) | ||
| on_before_node_added.(to_child) | ||
| # replace the child | ||
| GenDOM.Node.replace_child(from_node, to_child, from_child) |
Contributor
There was a problem hiding this comment.
I should probably add bang versions of the DOM functions as well. There are a ton of fire-and-forget DOM manipulation calls in client that we don't need to block on
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.