Add reference image guidance for diagram planning#258
Closed
simplaj wants to merge 1 commit into
Closed
Conversation
e98e628 to
5a1979f
Compare
Collaborator
Author
|
It appears this issue has already been fixed in other PRs, so I'll close this one for now. Thanks for your review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #223.
Adds and hardens reference/sketch image guidance for methodology diagram generation. The CLI validates repeatable
--imageinputs before pipeline start, the Planner attaches user-provided images after retrieved exemplars and labels their attached-image positions explicitly, and the Visualizer gets a lightweight note when a plan was sketch-guided. The Critic continues to judge only the generated output against the source text/caption.Changes
--imagepaths with PIL and normalize them to absolute paths before constructingGenerationInput.--imagebehavior while improving missing-file/non-raster error messages.input_image_countin progress and persistinput_imagesin planning metadata.--continueconflicts.Verification
.venv/bin/python -m pytest tests/test_pipeline/test_types.py tests/test_agents/test_planner.py tests/test_cli.py -k "image or input_images" -q-> 22 passed.venv/bin/python -m ruff check paperbanana/agents/planner.py paperbanana/agents/visualizer.py paperbanana/cli.py paperbanana/core/pipeline.py paperbanana/core/types.py tests/test_agents/test_planner.py tests/test_cli.py tests/test_pipeline/test_types.py-> passedgit diff --check origin/main...HEAD-> cleangit merge-tree $(git merge-base HEAD origin/main) HEAD origin/main-> clean