spack recipe: Add v0.15.0 and upstream components fix - #1973
Conversation
| "spin", | ||
| ) | ||
|
|
||
| _AXOM_COMPONENT_REQUIREMENTS = { |
There was a problem hiding this comment.
Is 'core' not included because everything depends on it?
Please double check this. It is inconsistent with the dependency figure in the Axom docs. For example, the diagram shows only that sina depends on core (not slic).
Also, how are optional dependencies handled here? For example quest optionally depends on sidre.
There was a problem hiding this comment.
Correct -- core is always on, and cannot be turned off.
@bmhan12 -- A brief comment might help clarify this.
There was a problem hiding this comment.
This list of requirements enables the minimal configuration of the user's requested components.
E.g. if they ask for inlet via component=inlet they will also get sidre since inlet requires sidre.
If they want more than the minimum, e.g. inlet and spin (and their hard dependencies), they can ask for components=inlet,spin.
There was a problem hiding this comment.
A brief comment might help clarify this.
Looks like a comment was already added above that section, where the components are listed out:
axom/scripts/spack/packages/axom/package.py
Lines 22 to 23 in 76874e2
3 participants
This PR:
Mirrors spack-packages PR: spack/spack-packages#6294