[BitcodeReader] Simplify CST_CODE_DATA constant parsing (NFC)#190846
Open
AlexMaclean wants to merge 1 commit intollvm:mainfrom
Open
[BitcodeReader] Simplify CST_CODE_DATA constant parsing (NFC)#190846AlexMaclean wants to merge 1 commit intollvm:mainfrom
AlexMaclean wants to merge 1 commit intollvm:mainfrom
Conversation
arsenm
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup boilerplate in the CST_CODE_DATA case for bitcode parser. This is generally an aesthetic improvement and can significantly reduce stack usage on some compilers (such as MSVC) where each SmallVector previously was allocated it's own individual space.