Skip to content

[mlir][ArmSME] Prefix SME streaming attributes with "llvm." for propagation #190864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joker-eph merged 1 commit into from
Apr 8, 2026
+25 −22
Merged

[mlir][ArmSME] Prefix SME streaming attributes with "llvm." for propagation #190864

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions mlir/lib/Dialect/ArmSME/Transforms/EnableArmStreaming.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ using namespace mlir::arm_sme;
namespace {

constexpr StringLiteral
kEnableArmStreamingIgnoreAttr("enable_arm_streaming_ignore");
kEnableArmStreamingIgnoreAttr("llvm.enable_arm_streaming_ignore");

template <typename... Ops>
constexpr auto opList() {
Expand Down Expand Up @@ -128,14 +128,17 @@ struct EnableArmStreamingPass

auto unitAttr = UnitAttr::get(&getContext());

function->setAttr(stringifyArmStreamingMode(streamingMode), unitAttr);
function->setDiscardableAttr(
(Twine("llvm.") + stringifyArmStreamingMode(streamingMode)).str(),
unitAttr);

// The pass currently only supports enabling ZA when in streaming-mode, but
// ZA can be accessed by the SME LDR, STR and ZERO instructions when not in
// streaming-mode (see section B1.1.1, IDGNQM of spec [1]). It may be worth
// supporting this later.
if (zaMode != ArmZaMode::Disabled)
function->setAttr(stringifyArmZaMode(zaMode), unitAttr);
function->setAttr((Twine("llvm.") + stringifyArmZaMode(zaMode)).str(),
unitAttr);
}
};
} // namespace
Expand Down
26 changes: 13 additions & 13 deletions mlir/test/Dialect/ArmSME/enable-arm-streaming.mlir
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,42 +6,42 @@
// RUN: mlir-opt %s -enable-arm-streaming=if-scalable-and-supported -verify-diagnostics | FileCheck %s -check-prefix=IF-SCALABLE

// CHECK-LABEL: @arm_streaming
// CHECK-SAME: attributes {arm_streaming}
// CHECK-SAME: attributes {llvm.arm_streaming}
// CHECK-LOCALLY-LABEL: @arm_streaming
// CHECK-LOCALLY-SAME: attributes {arm_locally_streaming}
// CHECK-LOCALLY-SAME: attributes {llvm.arm_locally_streaming}
// CHECK-COMPATIBLE-LABEL: @arm_streaming
// CHECK-COMPATIBLE-SAME: attributes {arm_streaming_compatible}
// CHECK-COMPATIBLE-SAME: attributes {llvm.arm_streaming_compatible}
// CHECK-ENABLE-ZA-LABEL: @arm_streaming
// CHECK-ENABLE-ZA-SAME: attributes {arm_new_za, arm_streaming}
// CHECK-ENABLE-ZA-SAME: attributes {llvm.arm_new_za, llvm.arm_streaming}
func.func @arm_streaming() { return }

// CHECK-LABEL: @not_arm_streaming
// CHECK-SAME: attributes {enable_arm_streaming_ignore}
// CHECK-SAME: attributes {llvm.enable_arm_streaming_ignore}
// CHECK-LOCALLY-LABEL: @not_arm_streaming
// CHECK-LOCALLY-SAME: attributes {enable_arm_streaming_ignore}
// CHECK-LOCALLY-SAME: attributes {llvm.enable_arm_streaming_ignore}
// CHECK-COMPATIBLE-LABEL: @not_arm_streaming
// CHECK-COMPATIBLE-SAME: attributes {enable_arm_streaming_ignore}
// CHECK-COMPATIBLE-SAME: attributes {llvm.enable_arm_streaming_ignore}
// CHECK-ENABLE-ZA-LABEL: @not_arm_streaming
// CHECK-ENABLE-ZA-SAME: attributes {enable_arm_streaming_ignore}
func.func @not_arm_streaming() attributes {enable_arm_streaming_ignore} { return }
// CHECK-ENABLE-ZA-SAME: attributes {llvm.enable_arm_streaming_ignore}
func.func @not_arm_streaming() attributes {llvm.enable_arm_streaming_ignore} { return }

// CHECK-LABEL: @requires_arm_streaming
// CHECK-SAME: attributes {arm_streaming}
// CHECK-SAME: attributes {llvm.arm_streaming}
// IF-REQUIRED: @requires_arm_streaming
// IF-REQUIRED-SAME: attributes {arm_streaming}
// IF-REQUIRED-SAME: attributes {llvm.arm_streaming}
func.func @requires_arm_streaming() {
%tile = arm_sme.get_tile : vector<[4]x[4]xi32>
return
}

// CHECK-LABEL: @does_not_require_arm_streaming
// CHECK-SAME: attributes {arm_streaming}
// CHECK-SAME: attributes {llvm.arm_streaming}
// IF-REQUIRED: @does_not_require_arm_streaming
// IF-REQUIRED-NOT: arm_streaming
func.func @does_not_require_arm_streaming() { return }

// IF-SCALABLE-LABEL: @contains_scalable_vectors
// IF-SCALABLE-SAME: attributes {arm_streaming}
// IF-SCALABLE-SAME: attributes {llvm.arm_streaming}
func.func @contains_scalable_vectors(%vec: vector<[4]xf32>) -> vector<[4]xf32> {
%0 = arith.addf %vec, %vec : vector<[4]xf32>
return %0 : vector<[4]xf32>
Expand Down
12 changes: 6 additions & 6 deletions mlir/test/Dialect/ArmSME/enable-arm-za.mlir
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,16 @@
func.func private @declaration()

// ENABLE-ZA-LABEL: @arm_new_za
// ENABLE-ZA-SAME: attributes {arm_new_za, arm_streaming}
// ENABLE-ZA-SAME: attributes {llvm.arm_new_za, llvm.arm_streaming}
// IN-ZA-LABEL: @arm_new_za
// IN-ZA-SAME: attributes {arm_in_za, arm_streaming}
// IN-ZA-SAME: attributes {llvm.arm_in_za, llvm.arm_streaming}
// OUT-ZA-LABEL: @arm_new_za
// OUT-ZA-SAME: attributes {arm_out_za, arm_streaming}
// OUT-ZA-SAME: attributes {llvm.arm_out_za, llvm.arm_streaming}
// INOUT-ZA-LABEL: @arm_new_za
// INOUT-ZA-SAME: attributes {arm_inout_za, arm_streaming}
// INOUT-ZA-SAME: attributes {llvm.arm_inout_za, llvm.arm_streaming}
// PRESERVES-ZA-LABEL: @arm_new_za
// PRESERVES-ZA-SAME: attributes {arm_preserves_za, arm_streaming}
// PRESERVES-ZA-SAME: attributes {llvm.arm_preserves_za, llvm.arm_streaming}
// DISABLE-ZA-LABEL: @arm_new_za
// DISABLE-ZA-NOT: arm_new_za
// DISABLE-ZA-SAME: attributes {arm_streaming}
// DISABLE-ZA-SAME: attributes {llvm.arm_streaming}
func.func @arm_new_za() { return }