Skip to content

[libc++] Don't use copy_file_impl_fstream when not declared #214706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AnthonyLatsis wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

[libc++] Don't use copy_file_impl_fstream when not declared #214706

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libcxx/src/filesystem/operations.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@ bool copy_file_impl(FileDescriptor& read_fd, FileDescriptor& write_fd, error_cod
ec.clear();
return true;
}
#elif defined(_LIBCPP_FILESYSTEM_USE_FSTREAM)
#elif defined(_LIBCPP_FILESYSTEM_USE_FSTREAM) && defined(_LIBCPP_FILESYSTEM_NEED_FSTREAM)

@ldionne ldionne Aug 11, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#elif defined(_LIBCPP_FILESYSTEM_USE_FSTREAM) && defined(_LIBCPP_FILESYSTEM_NEED_FSTREAM)
#elif defined(_LIBCPP_FILESYSTEM_USE_FSTREAM)

bool copy_file_impl(FileDescriptor& read_fd, FileDescriptor& write_fd, error_code& ec) {
return copy_file_impl_fstream(read_fd, write_fd, ec);

@ldionne ldionne Aug 11, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return copy_file_impl_fstream(read_fd, write_fd, ec);
# if !defined(_LIBCPP_FILESYSTEM_HAS_FSTREAM_FALLBACK)
# error copy_file intends to use std::fstream as a fallback, but std::fstream is not available in this configuration
# endif
return copy_file_impl_fstream(read_fd, write_fd, ec);

}
Expand Down
Loading