Skip to content

Fix create_completion capping all batch prompts to the shortest context's max_tokens #3867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Chessing234 wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −3
Open

Fix create_completion capping all batch prompts to the shortest context's max_tokens #3867

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions fastchat/serve/openai_api_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,9 +558,6 @@ async def create_completion(request: CompletionRequest):
if error_check_ret is not None:
return error_check_ret

if isinstance(max_tokens, int) and max_tokens < request.max_tokens:
request.max_tokens = max_tokens

if request.stream:
generator = generate_completion_stream_generator(
request, request.n, worker_addr
Expand Down
Loading