feat: add --limit and --page to accounts ls#1
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Adds pagination flags to the accounts ls CLI command to align with the project’s standard --page / --limit pattern used by other ls commands.
Changes:
- Add
--limitand--pageoptions tolobstr accounts lsand pass them through toclient.accounts.list(...). - Add
--limitas an alias forresults get --page-sizeto align results pagination with the same CLI flag naming.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/lobstr_cli/commands/accounts.py | Adds --limit/--page options to accounts ls and forwards them to the SDK call. |
| src/lobstr_cli/commands/results.py | Adds --limit alias for --page-size on results get for consistent pagination flags. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+16
to
+23
| def list_accounts( | ||
| limit: int = typer.Option(50, "--limit"), | ||
| page: int = typer.Option(1, "--page"), | ||
| ): | ||
| """List your accounts.""" | ||
| from lobstr_cli.cli import get_client, _state | ||
| client = get_client() | ||
| items = client.accounts.list() | ||
| items = client.accounts.list(limit=limit, page=page) |
Collaborator
Author
There was a problem hiding this comment.
@copilot apply changes based on this feedback
| output: Optional[str] = typer.Option(None, "--output", "-o", help="Save to file"), | ||
| page: int = typer.Option(1, "--page"), | ||
| page_size: int = typer.Option(50, "--page-size"), | ||
| page_size: int = typer.Option(50, "--page-size", "--limit"), |
Collaborator
Author
There was a problem hiding this comment.
@copilot apply changes based on this feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--limitand--pagepagination options toaccounts lscommandsquid ls,task ls,run lsTest plan
lobstr accounts ls --limit 10 --page 1🤖 Generated with Claude Code