Skip to content

feat(svelte): auto-destroy haptics on unmount #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shizukushq wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(svelte): auto-destroy haptics on unmount #33

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
15f4915
feat(svelte): auto-destroy haptics on unmount
shizukushq Mar 19, 2026
c4d99b1
fix(site): use svelte 5 syntax in example
shizukushq Apr 30, 2026
627e038
fix(examples): use svelte 5 syntax
shizukushq Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions apps/svelte-example/src/App.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
<script lang="ts">
import { onDestroy } from 'svelte';
import { createWebHaptics } from 'web-haptics/svelte';
import { createWebHaptics } from "web-haptics/svelte";

const { trigger, destroy } = createWebHaptics();
onDestroy(destroy);
const { trigger } = createWebHaptics();
</script>

<div class="container">
Expand Down
3 changes: 3 additions & 0 deletions packages/web-haptics/src/svelte/createWebHaptics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { onDestroy } from "svelte";
import { WebHaptics } from "../lib/web-haptics";
import type {
HapticInput,
Expand All @@ -15,5 +16,7 @@ export function createWebHaptics(options?: WebHapticsOptions) {
const setDebug = (debug: boolean) => instance.setDebug(debug);
const isSupported = WebHaptics.isSupported;

onDestroy(destroy);

return { trigger, cancel, destroy, setDebug, isSupported };
}
4 changes: 1 addition & 3 deletions site/src/surfaces/usage/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,7 @@ const { trigger } = useWebHaptics();
</template>`,
svelte: `<script>
import { createWebHaptics } from "web-haptics/svelte";
import { onDestroy } from "svelte";
const { trigger, destroy } = createWebHaptics();
onDestroy(destroy);
const { trigger } = createWebHaptics();
</script>

<button on:click={() => trigger()}>Tap me</button>`,
Comment thread
shizukushq marked this conversation as resolved.
Outdated
Expand Down