Fix side effect of record modified affecting the next in line handler. - #12
Open
saffih wants to merge 1 commit into
Open
Fix side effect of record modified affecting the next in line handler.#12saffih wants to merge 1 commit into
saffih wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue
Hoover processing has a side effect modifying the LogRecord "msg" field.
The existing code handling a Log Record having a dict data as message is as follows:
convert the dict into json,
update the record.msg to reference that json ( modifying the original record)
delegating that record
Some OTHER log handler expecting the message as dict would fail,
It takes the record.msg which should have been a dict and since hoover has changed that, it is now a json.
The fix
Hoover use a modified shallow copy instead of actually modifying the log record.
Using python shallow clone copy.copy which is modified and used by hoover. The original LogRecord does not change.