test(v2): add e2e cases for v2 block disk device recovery - #3678
Open
derekbit wants to merge 1 commit into
Open
Conversation
Add negative cases for a disk whose device is left detached from the kernel, for the device release on disk removal, and for the release after an instance manager restart, plus a regression case for the remove and re-add cycle. Add node helpers to detect a PCI BDF path, query the device driver, bind and unbind it, and wait for a disk to become schedulable. A device is treated as detached when it is bound to a userspace PCI driver or to no driver at all, since an interrupted bind can leave either state. The cases skip on a non-BDF disk path, where the scenario cannot be reproduced. Longhorn 13893 Signed-off-by: Derek Su <derek.su@suse.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue longhorn/longhorn#13893
What this PR does / why we need it:
Add negative cases for a disk whose device is left detached from the kernel, for the device release on disk removal, and for the release after an instance manager restart, plus a regression case for the remove and re-add cycle. Add node helpers to detect a PCI BDF path, query the device driver, bind and unbind it, and wait for a disk to become schedulable. A device is treated as detached when it is bound to a userspace PCI driver or to no driver at all, since an interrupted bind can leave either state. The cases skip on a non-BDF disk path, where the scenario cannot be reproduced.
Special notes for your reviewer:
Additional documentation or context