Skip to content
This repository was archived by the owner on Jan 22, 2021. It is now read-only.

Removed package.json to avoid installing outdated node-sass#95

Open
KoenLav wants to merge 1 commit into
lookback:masterfrom
KoenLav:master
Open

Removed package.json to avoid installing outdated node-sass#95
KoenLav wants to merge 1 commit into
lookback:masterfrom
KoenLav:master

Conversation

@KoenLav

@KoenLav KoenLav commented Mar 11, 2018

Copy link
Copy Markdown

With this package.json in the repository any Meteor application making use of this package will install an outdated version of node-sass, causing the bundle to grow with several megabytes (to include an outdated version of phantomjs).

@brookback

Copy link
Copy Markdown
Contributor

Oh, I didn't know Meteor is traversing a package tree to find a package.json.

But that'll break the example app – would you mind renaming the directory to .example instead? That'll hide it from Meteor.

@adamgins

Copy link
Copy Markdown

@brookback any thoughts to accept this?
just linking here #96

@brookback

Copy link
Copy Markdown
Contributor

@adamgins I'll have a look asap.

@adamgins

Copy link
Copy Markdown

Thanks @brookback

@bduff9

bduff9 commented Aug 9, 2018

Copy link
Copy Markdown

Any movement on this? Trying to install lookback and its failing my entire build with the 404 on the node-sass even though node-sass is installed as a dependency in my package.json. Would appreciate any help asap. Thanks!

@brookback

Copy link
Copy Markdown
Contributor

@bduff9 Feel for trying this branch: fix/hide-example-app, if you clone down this package into the packages dir in your app. I've renamed the example dir to .example to make Meteor ignore it and its package.json file. Thanks!

@noahsw

noahsw commented Sep 1, 2018

Copy link
Copy Markdown

@brookback but that branch still has

'chrisbutler:node-sass@3.2.0',

Won't that still include node-sass?

@brookback

Copy link
Copy Markdown
Contributor

@noahsw It's marked as weak, so afaik, it won't be explicitly depended on.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants