Fix missing null check for file read in binary parser#3
Open
prjanitor wants to merge 1 commit intolowRISC:masterfrom
Open
Fix missing null check for file read in binary parser#3prjanitor wants to merge 1 commit intolowRISC:masterfrom
prjanitor wants to merge 1 commit intolowRISC:masterfrom
Conversation
The get_elf_header function now verifies that the file read operation succeeded before accessing the header contents. This prevents undefined behavior when processing corrupted or empty ELF files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug in the
get_elf_headerfunction inbinary_parser.ccwhere the file read operation was not verified before accessing the header contents.Changes
Added a check after
file.read()to verify:!file)file.gcount() != sizeof(Elf64_Ehdr))Throws a descriptive
std::runtime_errorif the read failsImpact
This prevents undefined behavior when processing corrupted or empty ELF files, providing a clear error message instead of potentially crashing or producing incorrect results.
This PR was generated by PRJanitor — an automated tool that finds and fixes small bugs in open-source projects.
We respect your contribution guidelines — if your project doesn't accept bot PRs, we won't send more. You can also add a
.github/prjanitor.ymlfile withenabled: falseto opt out explicitly.