Extract a symlink's target type if possible, so it can have proper colors.

[dsully]

Extract a symlink's target type if possible, so it can have proper colors.

Before:

After:

---

• Use cargo fmt
• Add necessary tests
• Add changelog entry

[codecov-commenter]

Codecov Report

Merging #563 (ea64953) into master (74c1206) will decrease coverage by 0.35%.
The diff coverage is 20.00%.

@@            Coverage Diff             @@
##           master     #563      +/-   ##
==========================================
- Coverage   86.73%   86.38%   -0.36%     
==========================================
  Files          37       37              
  Lines        3800     3819      +19     
==========================================
+ Hits         3296     3299       +3     
- Misses        504      520      +16     

Impacted Files	Coverage Δ
src/meta/symlink.rs	55.84% <20.00%> (-13.13%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74c1206...ea64953. Read the comment docs.

[zwpaper]

oh, my bad, I got you wrong! could you add some tests for this feature and we can pass the CI

[dsully]

Hey, what sort of tests would you like? Since it's pretty much just pattern matching.

[zwpaper]

like the test here, it checks the invalid target color, IMO, you can add some tests like this testing some of newly added cases

[zwpaper]

Maybe It looks a little dumb by adding tests for pattern matching, but this is how we kept the functionalities working as expected during the code changes.

[meain]

We should probably colors the items using lscolors and not just builtin colors.

[zwpaper]

@meain the coloring is using the default mechanism, it would already use the LSCOLOR if I get the coloring logic right.

[meain]

Ahh, my bad I misread what the code was doing.

@dsully I found a small issue in the code. If the symlink is relative and we are not calling lsd from the same directory that it was symlinked from, it does not work.

cd /tmp
mkdir -p test/{a,b}
cd test
touch a/file
cd b
ln -s ../a/file file
cd ..
lsd -ld b/file

[dsully]

Ok, I'll take a look.