Add test using type in @module and @submodule#378
Open
BiterUnion wants to merge 1 commit intolunarmodules:masterfrom
Open
Add test using type in @module and @submodule#378BiterUnion wants to merge 1 commit intolunarmodules:masterfrom
BiterUnion wants to merge 1 commit intolunarmodules:masterfrom
Conversation
Adds a test using @type in @module and @submodule.
Member
|
This MWE looks great. I'll have to dig into how to trigger it so our CI starts showing the failure from this being a bug. Again I'll be traveling until mid October so not sure anything will get squeezed in from the road, but if anybody else wants to dig in to where the bug revealed by this MWE is I'll try to facilitate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a test using the
@typetag in both a@moduleand@submodule. It shows that the generated docs are different for both cases:Type2InModuleis properly shown as a class, whileType2InSubmoduleis not. Instead, onlyType2InSubmodule's functions are shown.