Skip to content

Apply discounts on guest carts when max_uses_per_user is set #2470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
glennjacobs wants to merge 1 commit into
base: 1.x
Choose a base branch
from
+151 −2
Draft

Apply discounts on guest carts when max_uses_per_user is set #2470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/core/src/DiscountTypes/AbstractDiscountType.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,8 @@ protected function checkDiscountConditions(CartContract $cart): bool

$validMaxUses = $this->discount->max_uses ? $this->discount->uses < $this->discount->max_uses : true;

if ($validMaxUses && $this->discount->max_uses_per_user) {
$validMaxUses = $cart->user && ($this->usesByUser($cart->user) < $this->discount->max_uses_per_user);
if ($validMaxUses && $this->discount->max_uses_per_user && $cart->user) {
$validMaxUses = $this->usesByUser($cart->user) < $this->discount->max_uses_per_user;
}

return $validCoupon && $validMinSpend && $validMaxUses;
Expand Down
149 changes: 149 additions & 0 deletions tests/core/Unit/DiscountTypes/AbstractDiscountTypeTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
use Lunar\Models\Product;
use Lunar\Models\ProductVariant;
use Lunar\Tests\Core\Stubs\TestAbstractDiscount;
use Lunar\Tests\Core\Stubs\User;
use Lunar\Tests\Core\TestCase;

uses(TestCase::class);
Expand Down Expand Up @@ -93,3 +94,151 @@

expect($cart->subTotalDiscounted->value)->toBe(900);
});

test('applies a discount with max uses per user on a guest cart', function () {
$channel = Channel::getDefault();
$currency = Currency::getDefault();

$cart = Cart::factory()->create([
'channel_id' => $channel->id,
'currency_id' => $currency->id,
'coupon_code' => '10OFF',
]);

Discount::factory()->create([
'type' => TestAbstractDiscount::class,
'name' => 'Test Coupon',
'coupon' => '10OFF',
'max_uses_per_user' => 1,
'data' => [
'fixed_value' => true,
'fixed_values' => [
'GBP' => 10,
],
],
]);

$purchasable = ProductVariant::factory()->create([
'product_id' => Product::factory(),
]);

Price::factory()->create([
'price' => 1000,
'min_quantity' => 1,
'currency_id' => $currency->id,
'priceable_type' => $purchasable->getMorphClass(),
'priceable_id' => $purchasable->id,
]);

$cart->lines()->create([
'purchasable_type' => $purchasable->getMorphClass(),
'purchasable_id' => $purchasable->id,
'quantity' => 1,
]);

$cart->calculate();

expect($cart->subTotalDiscounted->value)->toBe(900);
});

test('applies a discount when the user is under the per-user limit', function () {
setAuthUserConfig();

$channel = Channel::getDefault();
$currency = Currency::getDefault();
$user = User::factory()->create();

$cart = Cart::factory()->create([
'channel_id' => $channel->id,
'currency_id' => $currency->id,
'coupon_code' => '10OFF',
'user_id' => $user->id,
]);

Discount::factory()->create([
'type' => TestAbstractDiscount::class,
'name' => 'Test Coupon',
'coupon' => '10OFF',
'max_uses_per_user' => 2,
'data' => [
'fixed_value' => true,
'fixed_values' => [
'GBP' => 10,
],
],
]);

$purchasable = ProductVariant::factory()->create([
'product_id' => Product::factory(),
]);

Price::factory()->create([
'price' => 1000,
'min_quantity' => 1,
'currency_id' => $currency->id,
'priceable_type' => $purchasable->getMorphClass(),
'priceable_id' => $purchasable->id,
]);

$cart->lines()->create([
'purchasable_type' => $purchasable->getMorphClass(),
'purchasable_id' => $purchasable->id,
'quantity' => 1,
]);

$cart->calculate();

expect($cart->subTotalDiscounted->value)->toBe(900);
});

test('does not apply a discount when the user is at the per-user limit', function () {
setAuthUserConfig();

$channel = Channel::getDefault();
$currency = Currency::getDefault();
$user = User::factory()->create();

$cart = Cart::factory()->create([
'channel_id' => $channel->id,
'currency_id' => $currency->id,
'coupon_code' => '10OFF',
'user_id' => $user->id,
]);

$discountModel = Discount::factory()->create([
'type' => TestAbstractDiscount::class,
'name' => 'Test Coupon',
'coupon' => '10OFF',
'max_uses_per_user' => 1,
'data' => [
'fixed_value' => true,
'fixed_values' => [
'GBP' => 10,
],
],
]);

$discountModel->users()->attach($user->id);

$purchasable = ProductVariant::factory()->create([
'product_id' => Product::factory(),
]);

Price::factory()->create([
'price' => 1000,
'min_quantity' => 1,
'currency_id' => $currency->id,
'priceable_type' => $purchasable->getMorphClass(),
'priceable_id' => $purchasable->id,
]);

$cart->lines()->create([
'purchasable_type' => $purchasable->getMorphClass(),
'purchasable_id' => $purchasable->id,
'quantity' => 1,
]);

$cart->calculate();

expect($cart->subTotalDiscounted->value)->toBe(1000);
});