feat: add durable metadata and single-node recovery - #19
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (27)
📝 WalkthroughWalkthroughThe PR adds durable single-node execution with versioned metadata, fenced leases, idempotent scheduling, object-storage batch staging, worker processes, and checkpoint-based recovery after worker termination. ChangesDurable execution
Estimated code review effort: 5 (Critical) | ~120 minutes Sequence Diagram(s)sequenceDiagram
participant Scheduler
participant MetadataStore
participant Worker
participant ObjectStorage
participant Target
Scheduler->>MetadataStore: enqueue idempotent run command
Worker->>MetadataStore: claim run lease
Worker->>ObjectStorage: stage batch artifact
Worker->>MetadataStore: commit batch and checkpoint
Worker->>Target: publish staged batch
Worker->>MetadataStore: record events and final state
Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
partitions, batches, events, artifacts, checkpoints, schedules, and transactional outbox records
leases, heartbeats, fencing tokens, cooperative cancellation, and retry categories
loafer enqueueandloafer workerworker termination
Why
The bounded data plane could publish atomically, but its run metadata and checkpoints were not
durable enough to observe or resume work after a process failure. This change establishes the
single-node recovery contract before distributed transport is introduced.
Recovery contract
Durable replay is advertised for stable offset-ordered, row-local, single-partition runs. SQLite
is restricted to one scheduler and one worker; PostgreSQL is the authoritative platform profile.
Materialized/global transforms still restart as whole runs.
Validation
uv run pytest -q --tb=short: 752 passed, 56 skipped, 10 pre-existing stress-test warningsuv run ruff check loafer testsSummary by CodeRabbit
New Features
enqueueandworkerCLI commands for separate scheduling and execution.Documentation
Tests