Skip to content

Fix typo in luxonis-ml dependency specification#215

Open
klemen1999 wants to merge 2 commits into
mainfrom
luxonis_ml_dependency
Open

Fix typo in luxonis-ml dependency specification#215
klemen1999 wants to merge 2 commits into
mainfrom
luxonis_ml_dependency

Conversation

@klemen1999
Copy link
Copy Markdown
Collaborator

@klemen1999 klemen1999 commented Jun 2, 2026

Purpose

Specification

None / not applicable

Dependencies & Potential Impact

None / not applicable

Deployment Plan

None / not applicable

Testing & Validation

None / not applicable

AI Usage

Assisted-by: AGENT_NAME:MODEL_VERSION [TOOL1] [TOOL2]

Submitted code was reviewed by a human: YES/NO

The author is taking the responsibility for the contribution: YES/NO

Summary by CodeRabbit

  • Chores
    • Updated dependency requirement format for improved compatibility.

@klemen1999 klemen1999 requested a review from dtronmans June 2, 2026 20:53
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 2, 2026

Review Change Stack

Warning

Review limit reached

@klemen1999, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 54 minutes and 24 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2d96b3df-9233-4031-a432-641b193db89c

📥 Commits

Reviewing files that changed from the base of the PR and between 2b2b0f1 and 118e3b7.

📒 Files selected for processing (1)
  • .github/workflows/unittests.yaml
📝 Walkthrough

Walkthrough

This PR updates the luxonis-ml dependency specification in requirements.txt to use the correct extra name format nn-archive instead of nn_archive, while keeping the version constraint unchanged at ~=0.8.0.

Changes

Dependency Extra Name Update

Layer / File(s) Summary
Dependency extra name correction
requirements.txt
The luxonis-ml package extra specification is updated from nn_archive to nn-archive to align with the correct package extra name format.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A tiny fix, but oh so neat,
nn-archive makes the extras sweet,
One underscore to hyphen's flight,
Dependencies dancing just right! 🐰✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: correcting an underscore to a hyphen in the luxonis-ml dependency extra name from nn_archive to nn-archive.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch luxonis_ml_dependency

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@requirements.txt`:
- Line 6: The extras name for the luxonis-ml dependency is inconsistent between
requirements.txt and CI: update the extras to match exactly across both places
so CI and local installs use the same extras; specifically, change the extras
list for luxonis-ml (luxonis-ml[data,nn-archive,utils]) in either
requirements.txt or the GitHub Actions workflow
(.github/workflows/unittests.yaml) so the token "nn-archive" vs "nn_archive" is
identical in both, then run a quick install in CI or locally to verify no
install errors occur.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ad7c2d01-81a2-4fbc-be3e-436aedb40187

📥 Commits

Reviewing files that changed from the base of the PR and between edbe7da and 2b2b0f1.

📒 Files selected for processing (1)
  • requirements.txt

Comment thread requirements.txt
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 2, 2026

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
30404 6515 21% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 118e3b7 by action🐍

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 2, 2026

Test Results

  6 files    6 suites   22m 50s ⏱️
 26 tests  26 ✅ 0 💤 0 ❌
156 runs  156 ✅ 0 💤 0 ❌

Results for commit 118e3b7.

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants