ci(release): avoid building benchmarks on publish by colinaaa · Pull Request #1664 · lynx-family/lynx-stack

colinaaa · 2025-09-08T02:02:55Z

Following up #1629.

Summary by CodeRabbit

Chores
- Updated the main-branch deployment workflow to exclude internal benchmarking components from the publish build, reducing CI duration and minimizing unnecessary build work.
- Improves pipeline efficiency and stability, leading to faster feedback on releases without altering application functionality or release artifacts.
- No changes to error handling or other workflow steps; both regular and canary publish paths remain unaffected.

Checklist

Tests updated (or not required).
Documentation updated (or not required).
Changeset added, and when a BREAKING CHANGE occurs, it needs to be clearly marked (or not required).

changeset-bot · 2025-09-08T02:02:59Z

⚠️ No Changeset found

Latest commit: 1f59678

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2025-09-08T02:03:03Z

📝 Walkthrough

Walkthrough

The deploy-main GitHub Actions workflow updates the Turbo build filters in the publish job to additionally exclude benchx_cli and packages matching @lynx-js/benchmark-*. No other steps or logic are changed; canary publish remains unchanged.

Changes

Cohort / File(s)	Summary of Changes
CI workflow `\.github/workflows/deploy-main.yml`	In the publish job’s Turbo build step, added filters `--filter !benchx_cli` and `--filter "!@lynx-js/benchmark-*"` alongside the existing exclusion for `@lynx-js/web-tests`. No other workflow steps modified.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

ci(release): avoid building benchmark #1629 — Also updates .github/workflows/deploy-main.yml to add the same Turbo exclusion filters, directly overlapping in scope.
ci(benchmark/react): enable list in benchmark #1635 — Modifies benchmark tooling and benchx_cli scripts, related to the newly excluded packages in the publish build.

Suggested reviewers

upupming
PupilTong

Poem

I twitch my nose at CI’s new art,
Hop past benchmarks, keep the cart smart.
Filters set, the lanes are clear,
Publish hops without a fear.
Carrots cached, green checks near—
Boing! to main, we volunteer. 🥕🐇

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov · 2025-09-08T02:07:17Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (3)

.github/workflows/deploy-main.yml (3)

50-52: Quote all negation filters for shell-safety and consistency.

Minor: quote the ! filters here as well.

-          corepack pnpm turbo --filter !@lynx-js/web-tests --filter !benchx_cli --filter "!@lynx-js/benchmark-*" build --summarize
+          corepack pnpm turbo --filter "!@lynx-js/web-tests" --filter "!benchx_cli" --filter "!@lynx-js/benchmark-*" build --summarize

139-141: Use $GITHUB_OUTPUT instead of deprecated set-output.

GitHub deprecated ::set-output::.

-      - name: Get current date
-        id: date
-        run: echo "::set-output name=date::$(date -u +'%Y-%m-%d %H:%M:%S')"
+      - name: Get current date
+        id: date
+        run: echo "date=$(date -u +'%Y-%m-%d %H:%M:%S')" >> "$GITHUB_OUTPUT"

185-186: Consider excluding benchmarks in canary build too (time saver).

If canary doesn’t need benchmarks, mirror the publish filters.

-          corepack pnpm turbo --filter !@lynx-js/web-tests build --summarize
+          corepack pnpm turbo --filter "!@lynx-js/web-tests" --filter "!benchx_cli" --filter "!@lynx-js/benchmark-*" build --summarize

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 79d7030 and 1f59678.

📒 Files selected for processing (1)

.github/workflows/deploy-main.yml (1 hunks)

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2025-08-25T09:16:24.277Z

Learnt from: CR
PR: lynx-family/lynx-stack#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-08-25T09:16:24.277Z
Learning: Always run a full build with `pnpm turbo build` before running any tests

Applied to files:

.github/workflows/deploy-main.yml

🔇 Additional comments (1)

.github/workflows/deploy-main.yml (1)

137-138: Fix Turbo flag order: filters must precede the task.

Placing --filter after build may be ignored; this can still build benchmarks during publish.

Apply:

-          corepack pnpm turbo --filter !@lynx-js/web-tests build --filter !benchx_cli --filter "!@lynx-js/benchmark-*" --summarize
+          corepack pnpm turbo --filter "!@lynx-js/web-tests" --filter "!benchx_cli" --filter "!@lynx-js/benchmark-*" build --summarize

⛔ Skipped due to learnings

Learnt from: CR
PR: lynx-family/lynx-stack#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-08-25T09:16:24.277Z
Learning: Always run a full build with `pnpm turbo build` before running any tests

relativeci · 2025-09-08T02:15:30Z

React Example

#4875 Bundle Size — 238.02KiB (0%).

1f59678(current) vs 79d7030 main#4874(baseline)

Bundle metrics no changes

	Current #4875	Baseline #4874
Initial JS	`0B`	`0B`
Initial CSS	`0B`	`0B`
Cache Invalidation	`0%`	`0%`
Chunks	`0`	`0`
Assets	`4`	`4`
Modules	`160`	`160`
Duplicate Modules	`65`	`65`
Duplicate Code	`45.84%`	`45.84%`
Packages	`2`	`2`
Duplicate Packages	`0`	`0`

Bundle size by type no changes

	Current #4875	Baseline #4874
IMG	`145.76KiB`	`145.76KiB`
Other	`92.26KiB`	`92.26KiB`

Bundle analysis report Branch colinaaa:colin/0908/release Project dashboard

^{Generated by RelativeCI Documentation Report issue}

relativeci · 2025-09-08T02:15:34Z

Web Explorer

#4866 Bundle Size — 367.43KiB (0%).

1f59678(current) vs 79d7030 main#4865(baseline)

Bundle metrics

1 change

	Current #4866	Baseline #4865
Initial JS	`144.23KiB`	`144.23KiB`
Initial CSS	`31.84KiB`	`31.84KiB`
Cache Invalidation	`0%`	`0%`
Chunks	`8`	`8`
Assets	`8`	`8`
Modules	`217`(`-0.46%`)	`218`
Duplicate Modules	`16`	`16`
Duplicate Code	`3.33%`	`3.33%`
Packages	`4`	`4`
Duplicate Packages	`0`	`0`

Bundle size by type no changes

	Current #4866	Baseline #4865
JS	`235.43KiB`	`235.43KiB`
Other	`100.16KiB`	`100.16KiB`
CSS	`31.84KiB`	`31.84KiB`

Bundle analysis report Branch colinaaa:colin/0908/release Project dashboard

^{Generated by RelativeCI Documentation Report issue}

codspeed-hq · 2025-09-08T02:18:55Z

CodSpeed Performance Report

Merging #1664 will improve performances by 12.82%

_{Comparing colinaaa:colin/0908/release (1f59678) with main (79d7030)}

Summary

⚡ 1 improvements
✅ 41 untouched benchmarks

Benchmarks breakdown

	Benchmark	`BASE`	`HEAD`	Change
⚡	`basic-performance-nest-level-100`	6.6 ms	5.9 ms	+12.82%

ci(release): avoid building benchmarks on publish

1f59678

coderabbitai Bot reviewed Sep 8, 2025

View reviewed changes

colinaaa merged commit 6f6c420 into lynx-family:main Sep 8, 2025
44 of 46 checks passed

colinaaa deleted the colin/0908/release branch September 8, 2025 02:21

This was referenced Sep 9, 2025

ci: fix canary publish failed #1700

Merged

chore(benchmark): should bypass ECOSYSTEM_CI env #1702

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci(release): avoid building benchmarks on publish#1664

ci(release): avoid building benchmarks on publish#1664
colinaaa merged 1 commit intolynx-family:mainfrom
colinaaa:colin/0908/release

colinaaa commented Sep 8, 2025 •

edited by coderabbitai Bot

Loading

Uh oh!

changeset-bot Bot commented Sep 8, 2025

Uh oh!

coderabbitai Bot commented Sep 8, 2025 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

codecov Bot commented Sep 8, 2025 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

relativeci Bot commented Sep 8, 2025

Uh oh!

relativeci Bot commented Sep 8, 2025

Uh oh!

codspeed-hq Bot commented Sep 8, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

colinaaa commented Sep 8, 2025 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Checklist

Uh oh!

changeset-bot Bot commented Sep 8, 2025

⚠️ No Changeset found

Uh oh!

coderabbitai Bot commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

codecov Bot commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

relativeci Bot commented Sep 8, 2025

React Example

#4875 Bundle Size — 238.02KiB (0%).

Uh oh!

relativeci Bot commented Sep 8, 2025

Web Explorer

#4866 Bundle Size — 367.43KiB (0%).

Uh oh!

codspeed-hq Bot commented Sep 8, 2025

CodSpeed Performance Report

Merging #1664 will improve performances by 12.82%

Summary

Benchmarks breakdown

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

colinaaa commented Sep 8, 2025 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Sep 8, 2025 •

edited

Loading

codecov Bot commented Sep 8, 2025 •

edited

Loading