feat(react): optimize the number and depth of snapshot#1764
feat(react): optimize the number and depth of snapshot#1764upupming merged 54 commits intolynx-family:mainfrom
Conversation
🦋 Changeset detectedLatest commit: afd2d6a The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThis PR introduces slot index tracking ( Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
React Example#7436 Bundle Size — 224.28KiB (+0.41%).afd2d6a(current) vs 9e149c4 main#7425(baseline) Bundle metrics
Bundle size by type
Bundle analysis report Branch hzy:p/hzy/opt-slot_0 Project dashboard Generated by RelativeCI Documentation Report issue |
Web Explorer#9011 Bundle Size — 898.15KiB (0%).afd2d6a(current) vs 9e149c4 main#8999(baseline) Bundle metrics
|
| Current #9011 |
Baseline #8999 |
|
|---|---|---|
44.47KiB |
44.47KiB |
|
2.22KiB |
2.22KiB |
|
0% |
0.24% |
|
9 |
9 |
|
11 |
11 |
|
230 |
230 |
|
11 |
11 |
|
27.21% |
27.21% |
|
10 |
10 |
|
0 |
0 |
Bundle size by type no changes
| Current #9011 |
Baseline #8999 |
|
|---|---|---|
494.3KiB |
494.3KiB |
|
401.63KiB |
401.63KiB |
|
2.22KiB |
2.22KiB |
Bundle analysis report Branch hzy:p/hzy/opt-slot_0 Project dashboard
Generated by RelativeCI Documentation Report issue
Merging this PR will degrade performance by 22.68%
Performance Changes
Comparing Footnotes
|
c918ede to
df58cf7
Compare
df58cf7 to
1d78086
Compare
1d78086 to
b109ea2
Compare
|
I think we can safely remove lynx-stack/packages/react/runtime/src/snapshot.ts Lines 79 to 94 in 886715b It seems we cannot remove this since we want to be compatible with lower version lazy bundle. |
0d1a1d0 to
c165c4c
Compare
React External#554 Bundle Size — 582.19KiB (+0.31%).afd2d6a(current) vs 9e149c4 main#542(baseline) Bundle metrics
Bundle size by type
Bundle analysis report Branch hzy:p/hzy/opt-slot_0 Project dashboard Generated by RelativeCI Documentation Report issue |
React MTF Example#569 Bundle Size — 195.44KiB (+0.76%).afd2d6a(current) vs 9e149c4 main#557(baseline) Bundle metrics
Bundle size by type
Bundle analysis report Branch hzy:p/hzy/opt-slot_0 Project dashboard Generated by RelativeCI Documentation Report issue |
efd07a5 to
60b047a
Compare
4da2640 to
cfb0a4b
Compare
This reverts commit f18bbf3.
a28b4ca to
afd2d6a
Compare
Summary by CodeRabbit
New Features
$0,$1, etc.) for flexible content injection.Refactor
Tests
See preact changes at: lynx-family/internal-preact#1
Checklist