Skip to content

chore: rename react -> reactlynx#2099

Merged
PupilTong merged 1 commit intolynx-family:mainfrom
PupilTong:p/hw/rename-e2e-react-to-reactlynx
Jan 8, 2026
Merged

chore: rename react -> reactlynx#2099
PupilTong merged 1 commit intolynx-family:mainfrom
PupilTong:p/hw/rename-e2e-react-to-reactlynx

Conversation

@PupilTong
Copy link
Copy Markdown
Collaborator

@PupilTong PupilTong commented Jan 8, 2026

Summary by CodeRabbit

  • Chores

    • Refactored test infrastructure by consolidating test utilities into a dedicated public package.
    • Adjusted test timing parameters to improve reliability of test scenarios.
  • Tests

    • Removed obsolete test case for API custom template loader.
    • Updated test interactions to use direct DOM element queries instead of global object access patterns.

✏️ Tip: You can customize this high-level summary in your review settings.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).
  • Changeset added, and when a BREAKING CHANGE occurs, it needs to be clearly marked (or not required).

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jan 8, 2026

⚠️ No Changeset found

Latest commit: 070e561

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@PupilTong PupilTong self-assigned this Jan 8, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 8, 2026

📝 Walkthrough

Walkthrough

This PR removes the local coverage-fixture test helper and migrates test infrastructure to the external @lynx-js/playwright-fixtures package. The reactlynx.spec.ts test file is updated to import test utilities from the new package and refactors DOM interaction patterns from global method calls to direct element queries.

Changes

Cohort / File(s) Summary
Coverage fixture removal
packages/web-platform/web-core-wasm-e2e/tests/coverage-fixture.ts
Deleted 62-line test helper that extended Playwright's base test for JavaScript coverage collection on Chromium, including coverage start/stop logic and Istanbul format conversion
Test migration and refactoring
packages/web-platform/web-core-wasm-e2e/tests/reactlynx.spec.ts
Updated imports to use @lynx-js/playwright-fixtures instead of local coverage-fixture and utils; replaced globalThis.lynxView calls with DOM-based element queries; adjusted wait timings (200→1000, 100→200); switched timing assertions to toContainEqual; removed api-custom-template-loader test block; refactored worker count assertions

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested labels

platform:Web

Suggested reviewers

  • colinaaa
  • Sherry-hue

Poem

🐰 A fixture was born, now it flies away,
To a package more grand, where it'll stay,
DOM queries dance, timings align,
Tests migrate forth in a shimmer so fine,
Coverage captured, but handled elsewhere—
Refactoring magic floats through the air! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title check ⚠️ Warning The title 'chore: rename react -> reactlynx' is partially related to the changeset but misleading about the actual scope of changes made. Consider a more descriptive title that reflects the primary changes, such as 'refactor: migrate e2e tests to use @lynx-js/playwright-fixtures' or similar, as the changes involve significant migration beyond just renaming.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jan 8, 2026

Merging this PR will improve performance by 7.47%

Summary

⚡ 2 improved benchmarks
✅ 61 untouched benchmarks
⏩ 3 skipped benchmarks1

Performance Changes

Benchmark BASE HEAD Efficiency
transform 1000 view elements 46.7 ms 43.5 ms +7.47%
basic-performance-small-css 8.2 ms 7.7 ms +6.77%

Comparing PupilTong:p/hw/rename-e2e-react-to-reactlynx (070e561) with main (a91173c)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@PupilTong PupilTong requested a review from Sherry-hue January 8, 2026 09:56
@relativeci
Copy link
Copy Markdown

relativeci Bot commented Jan 8, 2026

Web Explorer

#7085 Bundle Size — 379.21KiB (0%).

070e561(current) vs a91173c main#7083(baseline)

Bundle metrics  Change 1 change
                 Current
#7085
     Baseline
#7083
No change  Initial JS 152.6KiB 152.6KiB
No change  Initial CSS 32.53KiB 32.53KiB
No change  Cache Invalidation 0% 0%
No change  Chunks 8 8
No change  Assets 8 8
Change  Modules 237(+0.85%) 235
No change  Duplicate Modules 16 16
No change  Duplicate Code 3.03% 3.03%
No change  Packages 4 4
No change  Duplicate Packages 0 0
Bundle size by type  no changes
                 Current
#7085
     Baseline
#7083
No change  JS 249.7KiB 249.7KiB
No change  Other 96.98KiB 96.98KiB
No change  CSS 32.53KiB 32.53KiB

Bundle analysis reportBranch PupilTong:p/hw/rename-e2e-react-...Project dashboard


Generated by RelativeCIDocumentationReport issue

@PupilTong PupilTong merged commit d4e7b0a into lynx-family:main Jan 8, 2026
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants