fix: Refactor useMotionValueRefCore into a dedicated file, introduc…

[f0rdream]

Refactor useMotionValueRefCore into a dedicated file, introduce a queueMicrotask polyfill for the mini package, and add dependency tests for the mini bundle.

Summary by CodeRabbit

• Bug Fixes

  • Fixed a compilation error when using the mini motion build.

• New Features

  • Added a lightweight polyfill to improve mini motion compatibility in environments without native microtask support.

• Tests

  • Added tests covering mini motion polyfill behavior and dependency restrictions.

• Chores

  • Recorded a patch release entry for the motion package and ensured the mini polyfill is included in the package metadata.

Checklist

• Tests updated (or not required).
• Documentation updated (or not required).
• Changeset added, and when a BREAKING CHANGE occurs, it needs to be clearly marked (or not required).

[changeset-bot]

🦋 Changeset detected

Latest commit: f7c0497

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@lynx-js/motion	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[coderabbitai]

📝 Walkthrough

Walkthrough

Core hook logic was moved to a new useMotionValueRefCore module; mini package imports adjusted and a mini-specific queueMicrotask polyfill was added and declared as side-effectful. New tests validate dependency isolation for mini and the polyfill behavior. A changeset bumps the motion patch version.

Changes

Cohort / File(s)	Summary
Changelog & Package \.changeset/true-teeth-cry.md, packages/motion/package.json	Added a changeset recording a patch for @lynx-js/motion; added ./dist/mini/polyfill.js to sideEffects.
Hook refactor packages/motion/src/hooks/useMotionValueRef.ts, packages/motion/src/hooks/useMotionValueRefCore.ts	Extracted core implementation to useMotionValueRefCore.ts; useMotionValueRef.ts now re-exports the core and delegates initialization.
Mini module & polyfill packages/motion/src/mini/index.ts, packages/motion/src/mini/polyfill.ts	Updated mini import paths; added a self-invoking queueMicrotask shim that prefers lynx.queueMicrotask and falls back to Promise+setTimeout error rethrowing.
Tests packages/motion/__tests__/dependencies.test.ts, packages/motion/__tests__/mini-polyfill.test.tsx	Added dependency-traversal test forbidding certain imports from mini; added runtime/unit tests for the mini polyfill behavior and queueMicrotask fallbacks.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• feat(react/runtime): delay the timing of runOnMainThread() #1667 — modifies runOnMainThread timing/behavior used by the new useMotionValueRefCore initialization bridging.

Suggested reviewers

• colinaaa
• Yradex

Poem

🐰 I hopped through hooks and moved their core,
A tiny shim to hush the microtask roar,
Tests peered down import paths with care,
Mini now stands lighter, patched, and aware—
✨ nibble, patch, and hop some more.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 40.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title accurately reflects the main objective of refactoring useMotionValueRefCore into a dedicated file and introducing a polyfill, which aligns with the changeset modifications.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

No actionable comments were generated in the recent review. 🎉

🧹 Recent nitpick comments

packages/motion/src/mini/polyfill.ts (1)

4-4: Nit: inconsistent casing — shimQueueMicroTask vs queueMicrotask.

The standard API uses lowercase t in "microtask" (queueMicrotask), but the function name capitalizes it (MicroTask). Consider shimQueueMicrotask for consistency.

packages/motion/__tests__/mini-polyfill.test.tsx (1)

110-141: Verify the error-rethrow test timing is sufficient.

The polyfill chains .then(fn).catch(handler), so the .catch callback runs one microtask tick after fn throws. Two await Promise.resolve() calls (lines 136–137) should be enough, but if this test becomes flaky, adding a third tick or using await vi.runAllTimersAsync() (with fake timers) would be more deterministic.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@packages/motion/__tests__/dependencies.test.ts`:
- Around line 22-30: The forbidden-file check currently compares the raw import
specifier `file` against `forbiddenFile` before path resolution, allowing
bypasses (e.g. `animation/index`, `animation/index.js`); move the forbidden
check to after resolution where `filePath` is computed (the block that resolves
`file` into `filePath` in the traversal logic), and perform the comparison
against the resolved path (normalize relative to `rootDir` the same way the
error message builds). Also change the `visited` set to use the resolved
`filePath` (not the raw `file`) so visits and forbiddens are consistent, and
ensure `pathStack` entries used in the thrown error are the resolved/normalized
paths for accurate diagnostics.

🧹 Nitpick comments (3)

packages/motion/src/mini/polyfill.ts (1)

4-22: Naming inconsistency: shimQueueMicroTask vs queueMicrotask.

The function name uses capital T in MicroTask while the standard API and all other references use lowercase t (queueMicrotask). Consider renaming to shimQueueMicrotask for consistency.

packages/motion/__tests__/mini-polyfill.test.tsx (1)

9-54: Test validates no-crash but not polyfill functionality.

The test confirms the mini module doesn't throw in a main-thread environment, which is the stated goal. However, the onComplete callback (lines 26-29) doesn't capture or assert anything, so the test doesn't verify that the polyfill's queueMicrotask actually works for async scheduling. Consider adding an assertion that the animation completes (e.g., checking mv.get() equals 100 after completion) in a follow-up if deeper coverage is desired.

packages/motion/__tests__/dependencies.test.ts (1)

17-18: Consider adding an explicit expect assertion for test clarity.

The test relies solely on thrown errors for failure, which works but may trigger "no assertions" warnings depending on vitest config. A trailing expect (e.g., expect(true).toBe(true)) or importing expect and using it after check() would make the intent more explicit. Low priority.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

[codspeed-hq]

CodSpeed Performance Report

Merging this PR will not alter performance

_{Comparing f0rdream:motion_mini_seperation (f7c0497) with main (fe5e578)}

Summary

✅ 63 untouched benchmarks
⏩ 3 skipped benchmarks¹

Footnotes

1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[relativeci]

Web Explorer

#7565 Bundle Size — 383.74KiB (0%).

f7c0497(current) vs fe5e578 main#7562(baseline)

Bundle metrics  no changes

	Current #7565	Baseline #7562
Initial JS	154.88KiB	154.88KiB
Initial CSS	35.06KiB	35.06KiB
Cache Invalidation	0%	40.36%
Chunks	8	8
Assets	8	8
Modules	239	239
Duplicate Modules	16	16
Duplicate Code	2.99%	2.99%
Packages	4	4
Duplicate Packages	0	0

Bundle size by type  no changes

	Current #7565	Baseline #7562
JS	252.82KiB	252.82KiB
Other	95.85KiB	95.85KiB
CSS	35.06KiB	35.06KiB

Bundle analysis report Branch f0rdream:motion_mini_seperation Project dashboard

---

^{Generated by RelativeCI Documentation Report issue}