fix: scope rspack overrides to preserve rsbuild2 dependencies by colinaaa · Pull Request #2497 · lynx-family/lynx-stack

colinaaa · 2026-04-21T11:44:32Z

Summary

scope pnpm overrides to @rspack/core@^1.7.0 and @rsbuild/core@1 instead of overriding all @rspack/core resolutions
keep @rsdoctor/* pinned to the workspace @rspack/core while allowing rsbuild2/rspress to resolve their required rspack v2 dependency
regenerate lockfile via install/dedupe so dependency graph and snapshots reflect the split v1/v2 rspack resolution

Verification

pnpm dedupe --check
pnpm turbo build

Summary by CodeRabbit

Chores
- Refined dependency override rules to be more targeted, improving resolution accuracy.
- Added additional override mappings for plugin/type packages to ensure consistent resolution against the core runtime.

changeset-bot · 2026-04-21T11:44:36Z

⚠️ No Changeset found

Latest commit: 562e504

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

chatgpt-codex-connector · 2026-04-21T11:44:37Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

coderabbitai · 2026-04-21T11:44:47Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f613c1fc-41e0-40ff-a401-d63f8e47bc6b

📥 Commits

Reviewing files that changed from the base of the PR and between 5ac2db1 and 562e504.

⛔ Files ignored due to path filters (1)

pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (1)

pnpm-workspace.yaml

🚧 Files skipped from review as they are similar to previous changes (1)

pnpm-workspace.yaml

📝 Walkthrough

Walkthrough

Adjusts pnpm workspace override rules in pnpm-workspace.yaml: narrows @rspack/core override to @rspack/core@^1, keeps @rsbuild/core@1>@rspack/core, and adds overrides mapping @rsdoctor/rspack-plugin and @rsdoctor/types to resolve via the pinned @rspack/core.

Changes

Cohort / File(s)	Summary
Workspace overrides `pnpm-workspace.yaml`	Refined dependency overrides: change generic `@rspack/core` override to `@rspack/core@^1`, preserve `@rsbuild/core@1>@rspack/core` mapping, and add overrides mapping `@rsdoctor/rspack-plugin` and `@rsdoctor/types` to use the `@rspack/core` resolution.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

chore(deps): bump rspack to 1.7.9 and swc helpers to 0.5.20 #2404: Pins @rspack/core to 1.7.9; directly related to override targets used here.
chore: bump rspack 1.7.0 #2087: Alters pnpm-workspace.yaml handling for @rspack/core; similar override/versioning changes.
chore(deps): bump rspack v1.6.1 #1909: Adjusts dependency resolution around @rspack/core; relevant to scoping of overrides.

Suggested reviewers

upupming
luhc228
PupilTong

Poem

🐰 I hopped through workspace lanes tonight,

Tweaked overrides to set things right.
Rspack pinned and rsdoctor steered,
Quiet installs, no chaos feared.
A tidy hop — dependencies cheered! 🥕

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly describes the main change: scoping rspack overrides to preserve rsbuild2 dependencies, which aligns with the PR's core objective of narrowing pnpm overrides to target specific versions instead of globally overriding all `@rspack/core` resolutions.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov · 2026-04-21T11:47:34Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

codspeed-hq · 2026-04-21T12:08:44Z

Merging this PR will degrade performance by 77.36%

⚠️

Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 79 untouched benchmarks
⏩ 26 skipped benchmarks¹

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Benchmark	`BASE`	`HEAD`	Efficiency
⚡	`002-hello-reactLynx-destroyBackground`	894.7 µs	670.1 µs	+33.51%
❌	`basic-performance-large-css`	15.3 ms	67.6 ms	-77.36%

_{Comparing colinaaa:fix/rspack-overrides-v1-scope (562e504) with main (02be891)}

26 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

relativeci · 2026-04-21T12:08:47Z

React External

#591 Bundle Size — 583.27KiB (0%).

562e504(current) vs 02be891 main#571(baseline)

Bundle metrics no changes

	Current #591	Baseline #571
Initial JS	`0B`	`0B`
Initial CSS	`0B`	`0B`
Cache Invalidation	`0%`	`0%`
Chunks	`0`	`0`
Assets	`3`	`3`
Modules	`17`	`17`
Duplicate Modules	`5`	`5`
Duplicate Code	`8.59%`	`8.59%`
Packages	`0`	`0`
Duplicate Packages	`0`	`0`

Bundle size by type no changes

	Current #591	Baseline #571
Other	`583.27KiB`	`583.27KiB`

Bundle analysis report Branch colinaaa:fix/rspack-overrides-v1... Project dashboard

^{Generated by RelativeCI Documentation Report issue}

relativeci · 2026-04-21T12:08:48Z

React Example

#7473 Bundle Size — 224.41KiB (0%).

562e504(current) vs 02be891 main#7453(baseline)

Bundle metrics no changes

	Current #7473	Baseline #7453
Initial JS	`0B`	`0B`
Initial CSS	`0B`	`0B`
Cache Invalidation	`0%`	`0%`
Chunks	`0`	`0`
Assets	`4`	`4`
Modules	`179`	`179`
Duplicate Modules	`69`	`69`
Duplicate Code	`44.5%`	`44.5%`
Packages	`2`	`2`
Duplicate Packages	`0`	`0`

Bundle size by type no changes

	Current #7473	Baseline #7453
IMG	`145.76KiB`	`145.76KiB`
Other	`78.65KiB`	`78.65KiB`

Bundle analysis report Branch colinaaa:fix/rspack-overrides-v1... Project dashboard

^{Generated by RelativeCI Documentation Report issue}

relativeci · 2026-04-21T12:10:18Z

React MTF Example

#606 Bundle Size — 195.57KiB (0%).

562e504(current) vs 02be891 main#586(baseline)

Bundle metrics no changes

	Current #606	Baseline #586
Initial JS	`0B`	`0B`
Initial CSS	`0B`	`0B`
Cache Invalidation	`0%`	`0%`
Chunks	`0`	`0`
Assets	`3`	`3`
Modules	`173`	`173`
Duplicate Modules	`66`	`66`
Duplicate Code	`43.99%`	`43.99%`
Packages	`2`	`2`
Duplicate Packages	`0`	`0`

Bundle size by type no changes

	Current #606	Baseline #586
IMG	`111.23KiB`	`111.23KiB`
Other	`84.34KiB`	`84.34KiB`

Bundle analysis report Branch colinaaa:fix/rspack-overrides-v1... Project dashboard

^{Generated by RelativeCI Documentation Report issue}

relativeci · 2026-04-21T12:10:23Z

Web Explorer

#9047 Bundle Size — 898.15KiB (0%).

562e504(current) vs 02be891 main#9028(baseline)

Bundle metrics no changes

	Current #9047	Baseline #9028
Initial JS	`44.47KiB`	`44.47KiB`
Initial CSS	`2.22KiB`	`2.22KiB`
Cache Invalidation	`0%`	`0%`
Chunks	`9`	`9`
Assets	`11`	`11`
Modules	`229`	`229`
Duplicate Modules	`11`	`11`
Duplicate Code	`27.22%`	`27.22%`
Packages	`10`	`10`
Duplicate Packages	`0`	`0`

Bundle size by type no changes

	Current #9047	Baseline #9028
JS	`494.3KiB`	`494.3KiB`
Other	`401.63KiB`	`401.63KiB`
CSS	`2.22KiB`	`2.22KiB`

Bundle analysis report Branch colinaaa:fix/rspack-overrides-v1... Project dashboard

^{Generated by RelativeCI Documentation Report issue}

fix: scope rspack overrides to preserve rsbuild2 deps

5ac2db1

fix: overrides

562e504

colinaaa merged commit e0712b9 into lynx-family:main Apr 22, 2026
101 of 108 checks passed

colinaaa deleted the fix/rspack-overrides-v1-scope branch April 22, 2026 03:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: scope rspack overrides to preserve rsbuild2 dependencies#2497

fix: scope rspack overrides to preserve rsbuild2 dependencies#2497
colinaaa merged 2 commits intolynx-family:mainfrom
colinaaa:fix/rspack-overrides-v1-scope

colinaaa commented Apr 21, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

changeset-bot Bot commented Apr 21, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot commented Apr 21, 2026

Uh oh!

coderabbitai Bot commented Apr 21, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

codecov Bot commented Apr 21, 2026 •

edited

Loading

Uh oh!

codspeed-hq Bot commented Apr 21, 2026 •

edited

Loading

Uh oh!

relativeci Bot commented Apr 21, 2026 •

edited

Loading

Uh oh!

relativeci Bot commented Apr 21, 2026 •

edited

Loading

Uh oh!

relativeci Bot commented Apr 21, 2026 •

edited

Loading

Uh oh!

relativeci Bot commented Apr 21, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

colinaaa commented Apr 21, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Verification

Summary by CodeRabbit

Uh oh!

changeset-bot Bot commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

chatgpt-codex-connector Bot commented Apr 21, 2026

Uh oh!

coderabbitai Bot commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

codecov Bot commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

codspeed-hq Bot commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will degrade performance by 77.36%

Performance Changes

Footnotes

Uh oh!

relativeci Bot commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

React External

#591 Bundle Size — 583.27KiB (0%).

Uh oh!

relativeci Bot commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

React Example

#7473 Bundle Size — 224.41KiB (0%).

Uh oh!

relativeci Bot commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

React MTF Example

#606 Bundle Size — 195.57KiB (0%).

Uh oh!

relativeci Bot commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Web Explorer

#9047 Bundle Size — 898.15KiB (0%).

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

colinaaa commented Apr 21, 2026 •

edited by coderabbitai Bot

Loading

changeset-bot Bot commented Apr 21, 2026 •

edited

Loading

coderabbitai Bot commented Apr 21, 2026 •

edited

Loading

codecov Bot commented Apr 21, 2026 •

edited

Loading

codspeed-hq Bot commented Apr 21, 2026 •

edited

Loading

relativeci Bot commented Apr 21, 2026 •

edited

Loading

relativeci Bot commented Apr 21, 2026 •

edited

Loading

relativeci Bot commented Apr 21, 2026 •

edited

Loading

relativeci Bot commented Apr 21, 2026 •

edited

Loading