Notify about error/warnings #6

[mmalczak]

ARTIQ Pull Request

Description of Changes

Change the 'Log' tab color to yellow to notify about new warning and to red for errors and criticals.
The change is a hack.
I did not find any direct way to change the tab background color. I did not manage to make it work with stylesheets.
I imagine that there is some way to do it and would be grateful for some hint.
However, to make it work, I replaced the name of the tab with QLabel.
The behavior is ok, but it's not clean solution.

Type of Changes

	Type
✓	✨ New feature

Steps (Choose relevant, delete irrelevant before submitting)

All Pull Requests

• Use correct spelling and grammar.
• Check the copyright situation of your changes and sign off your patches (git commit --signoff, see copyright).

Code Changes

• Run flake8 to check code style (follow PEP-8 style). flake8 has issues with parsing Migen/gateware code, ignore as necessary.
• Test your changes or have someone test them. Mention what was tested and how.
• Add and check docstrings and comments
• Check, test, and update the unittests in /artiq/test/ or gateware simulations in /artiq/gateware/test

Licensing

See copyright & licensing for more info.
ARTIQ files that do not contain a license header are copyrighted by M-Labs Limited and are licensed under LGPLv3+.

[SimonRenblad]

Tab title disappears due to the QLabel hack.

• Does not account for the log filter / log level set.
• How does it handle multiple log docks?
• It is not opt-in which could quickly become annoying (it is an unblockable notification, essentially).

This seems to share very similar functionality to #2728, and therefore some of the same flaws.

Instead of changing the color of the tab, I would make the case for a status bar or other sensible ways to notify the user. This would also allow the number of errors/log messages to be displayed. Would also address #2728.

[marmeladapk]

A status bar would indeed be interesting and maybe should be broken out into an issue to discuss specifics (e.g. what else could we put there) and hammer out the design.
Unfortunately I don't think we'll have time to develop that in the near future. If the issues you outlined were solved would you be willing to merge it? If you'd rather not, then let us know and we'll focus on fixing issues on other PRs.

[SimonRenblad]

I would focus on the other PRs for now.