improve check required workflow#1249
Open
pavlovic-ivan wants to merge 1 commit intom4rs-mt:masterfrom
Open
Conversation
Co-authored-by: Jonathan Giannuzzi <jgiannuzzi@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by this PR.
This PR improves how we create the required check "All required checks succeeded" in the following ways:
queuedorin_progresswhen the corresponding workflow run's status changes. This is needed so that the check is reset when a new run attempt is made or a PR is reopened.The following tasks need to be completed before merging this PR:
check:writepermissionscreate-checkenvironment that can only be accessed by themain/masterbranchThe following tasks need to be completed after merging this PR:
Fixes: #1248