Pass igraph (per-event MLM graph) through Fortran bridge to SMATRIX_MULTI#1086
Pass igraph (per-event MLM graph) through Fortran bridge to SMATRIX_MULTI#1086
Conversation
Qubitol
left a comment
There was a problem hiding this comment.
So, I have 2 things which I'd change:
- I would squash/rebase the commits, so that we have only one single commit making the changes inside CODEGEN (also, it seems it didn't remove all the changes done elsewhere, so I'd remove them). I'm saying that because for MadGraph7 I'd like to cherry-pick the commit, and having unrelated things makes it more annoying.
- we can do a second commit that updates the processes (but in that case we use the script to properly regenerate all of them)
- I would upgrade
igraphto a class member (to be consistent with the rest), and not just a variable passed around
|
No problem for squashing.
I have asked the agent to do that (he will upgrade the PR)
Let's wait for the final form and then tackle that |
|
I think the core is done, but still there are changes in the various processes. I guess we can solve this by hand via interactive rebase. |
|
Ok I have asked the agent to remove the spurious change. Do we squash commit now? |
6dce342 to
5dbd7bf
Compare
…uble sourcing This fix requires also a fix upstream to remove the previous vector.inc sourcing.
9aa5ff8 to
d9b990c
Compare
af11d85 to
47bb3b6
Compare
Agent-Logs-Url: https://github.com/madgraph5/madgraph4gpu/sessions/4c9417fc-2ffa-4b23-9885-18f87879424b Co-authored-by: oliviermattelaer <33414646+oliviermattelaer@users.noreply.github.com>
47bb3b6 to
b449bc0
Compare
46368ad to
c1ff0ad
Compare
|
CI passes! We can merge as soon as MadGraph v3.7.1 is released, bumping the version beforehand here. |
igraph1_pageinprocess_sigmaKin_function.inc(CODEGEN only):igraph1_page→igraph1_ievt, now indexed byallIgraph[ievt](per-event) instead ofallIgraph[ievt00](first in page)for( int ieppV ... )loop soiconfigis determined per-eventtargetampfromfptype_sv(SIMD vector) tofptype(scalar), extracting lane[ieppV]viajamp2_sv[icolC][ieppV]in SIMD modevolatile(no longer needed with scalar targetamp)ievt2now has its own independent per-event igraph read (igraph1_ievt2 = allIgraph[ievt2]), its owniconfig2, and its owntargetamp2scalar array — all independent ofievt