Skip to content

Pass igraph (per-event MLM graph) through Fortran bridge to SMATRIX_MULTI#1086

Open
Copilot wants to merge 17 commits intomasterfrom
copilot/pass-igraph1-to-fortran-bridge
Open

Pass igraph (per-event MLM graph) through Fortran bridge to SMATRIX_MULTI#1086
Copilot wants to merge 17 commits intomasterfrom
copilot/pass-igraph1-to-fortran-bridge

Conversation

Copy link
Copy Markdown

Copilot AI commented Apr 12, 2026

  • Fix igraph1_page in process_sigmaKin_function.inc (CODEGEN only):
    • Renamed igraph1_pageigraph1_ievt, now indexed by allIgraph[ievt] (per-event) instead of allIgraph[ievt00] (first in page)
    • Moved the entire color-selection block inside the for( int ieppV ... ) loop so iconfig is determined per-event
    • Changed targetamp from fptype_sv (SIMD vector) to fptype (scalar), extracting lane [ieppV] via jamp2_sv[icolC][ieppV] in SIMD mode
    • Removed SIMD-only volatile (no longer needed with scalar targetamp)
    • For mixed-precision path: ievt2 now has its own independent per-event igraph read (igraph1_ievt2 = allIgraph[ievt2]), its own iconfig2, and its own targetamp2 scalar array — all independent of ievt

Copy link
Copy Markdown
Collaborator

@Qubitol Qubitol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, I have 2 things which I'd change:

  • I would squash/rebase the commits, so that we have only one single commit making the changes inside CODEGEN (also, it seems it didn't remove all the changes done elsewhere, so I'd remove them). I'm saying that because for MadGraph7 I'd like to cherry-pick the commit, and having unrelated things makes it more annoying.
  • we can do a second commit that updates the processes (but in that case we use the script to properly regenerate all of them)
  • I would upgrade igraph to a class member (to be consistent with the rest), and not just a variable passed around

@oliviermattelaer
Copy link
Copy Markdown
Member

No problem for squashing.

I would upgrade igraph to a class member (to be consistent with the rest), and not just a variable passed around

I have asked the agent to do that (he will upgrade the PR)

we can do a second commit that updates the processes (but in that case we use the script to properly regenerate all of them)

Let's wait for the final form and then tackle that

@Qubitol
Copy link
Copy Markdown
Collaborator

Qubitol commented Apr 13, 2026

I think the core is done, but still there are changes in the various processes. I guess we can solve this by hand via interactive rebase.

@oliviermattelaer
Copy link
Copy Markdown
Member

Ok I have asked the agent to remove the spurious change. Do we squash commit now?
or run the update script first? (or just squash now and then run the update script?)

@Qubitol Qubitol force-pushed the copilot/pass-igraph1-to-fortran-bridge branch from 6dce342 to 5dbd7bf Compare April 14, 2026 10:12
@Qubitol Qubitol self-requested a review April 14, 2026 16:55
@Qubitol Qubitol marked this pull request as ready for review April 14, 2026 16:55
@Qubitol Qubitol changed the title Pass igraph1 (per-event MLM graph) through Fortran bridge to SMATRIX_MULTI Pass igraph (per-event MLM graph) through Fortran bridge to SMATRIX_MULTI Apr 14, 2026
…uble sourcing

This fix requires also a fix upstream to remove the previous vector.inc
sourcing.
@oliviermattelaer oliviermattelaer requested a review from a team as a code owner April 15, 2026 09:34
@oliviermattelaer oliviermattelaer force-pushed the copilot/pass-igraph1-to-fortran-bridge branch 3 times, most recently from 9aa5ff8 to d9b990c Compare April 15, 2026 09:46
@Qubitol Qubitol force-pushed the copilot/pass-igraph1-to-fortran-bridge branch 3 times, most recently from af11d85 to 47bb3b6 Compare April 15, 2026 13:37
@Qubitol Qubitol force-pushed the copilot/pass-igraph1-to-fortran-bridge branch from 47bb3b6 to b449bc0 Compare April 15, 2026 14:19
@Qubitol Qubitol force-pushed the copilot/pass-igraph1-to-fortran-bridge branch from 46368ad to c1ff0ad Compare April 16, 2026 14:29
@Qubitol
Copy link
Copy Markdown
Collaborator

Qubitol commented Apr 16, 2026

CI passes! We can merge as soon as MadGraph v3.7.1 is released, bumping the version beforehand here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants