[SOC] Implement Zimone, Infinite Analyst#14861
Closed
muz wants to merge 1 commit intomagefree:masterfrom
Closed
Conversation
muz
force-pushed
the
soc_zimone_infinite_analyst
branch
from
1ea1057 to
23aca94
Compare
muz
force-pushed
the
soc_zimone_infinite_analyst
branch
from
23aca94 to
b59d294
Compare
xenohedron
reviewed
May 5, 2026
| // Whenever you cast your first spell with {X} in its mana cost each turn, put two +1/+1 counters on Zimone. | ||
| this.addAbility(new SpellCastControllerTriggeredAbility( | ||
| new AddCountersSourceEffect(CounterType.P1P1.createInstance(2)), filter, false | ||
| ).setTriggersLimitEachTurn(1)); |
Contributor
There was a problem hiding this comment.
Is this correct? Shouldn't it also be checking the watcher? Example, you cast a spell with {X} in mana cost, then you cast Zimone, then you cast another. Ability hasn't triggered yet but it still shouldn't.
Contributor
Author
There was a problem hiding this comment.
Ah good point, I had this using the watcher previously and thought "oh, can't we just do this to limit it". Turns out that sequence of events was why it made sense to go with the prior implementation I had 🤦
|
|
||
| @Override | ||
| public boolean apply(Game game, Ability source, Ability abilityToModify) { | ||
| Permanent sourcePermanent = game.getPermanent(source.getSourceId()); |
Contributor
There was a problem hiding this comment.
source.getSourcePermanentIfItStillExists(game)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked to #14651