You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Remove the unused ledger replay validator-authority override feature.
Details
Configuration
Removes ledger.replay-authority-override from LedgerConfig and the example config. This also removes the corresponding environment variable support for MBV_LEDGER__REPLAY_AUTHORITY_OVERRIDE through normal config deserialization.
The replica-mode authority override remains supported via validator.replication-mode.replica.authority-override.
Ledger restore tests
Removes integration test helpers and duplicate restore test variants that existed only to exercise the replay override path. The remaining ledger restore tests now use the standard validator setup paths.
Summary by CodeRabbit
Release Notes
Chores
Removed the optional validator authority override setting used during ledger replay.
Updated ledger restore and replay tests/utilities to stop accepting or using authority override inputs, and to consistently use standard validator initialization.
Adjusted related helper signatures and test assertions to match the simplified restore/replay workflow.
This PR removes the replay_authority_override feature entirely. The replay_authority_override: Option<SerdePubkey> field is deleted from the LedgerConfig struct along with its Default initialization, the SerdePubkey import is dropped, and the corresponding MBV_LEDGER__REPLAY_AUTHORITY_OVERRIDE documentation is removed from config.example.toml. Two exported test helper functions (setup_offline_validator_with_authority_override and setup_validator_with_local_remote_and_authority_override) are removed from the integration test library. All four ledger-restore integration test files are updated to drop the authority_override parameter from their local read/read_ledger helpers, remove the conditional branching that selected the override setup path, and remove now-unused imports.
Suggested reviewers
bmuddha
✨ Finishing Touches🧪 Generate unit tests (beta)
Create PR with unit tests
Commit unit tests in branch thlorenz/rm-val-override-replay
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the unused ledger replay validator-authority override feature.
Details
Configuration
Removes
ledger.replay-authority-overridefromLedgerConfigand the example config. This also removes the corresponding environment variable support forMBV_LEDGER__REPLAY_AUTHORITY_OVERRIDEthrough normal config deserialization.The replica-mode authority override remains supported via
validator.replication-mode.replica.authority-override.Ledger restore tests
Removes integration test helpers and duplicate restore test variants that existed only to exercise the replay override path. The remaining ledger restore tests now use the standard validator setup paths.
Summary by CodeRabbit
Release Notes