Skip to content

fix: return deactivate transaction errors#1321

Draft
thlorenz wants to merge 1 commit into
masterfrom
thlorenz/tablemania-deactivate-error-handling
Draft

fix: return deactivate transaction errors#1321
thlorenz wants to merge 1 commit into
masterfrom
thlorenz/tablemania-deactivate-error-handling

Conversation

@thlorenz

@thlorenz thlorenz commented Jun 14, 2026

Copy link
Copy Markdown
Collaborator

Summary

Ensure lookup table deactivation failures are returned to the caller instead of being treated as a successful local state transition.

Details

magicblock-table-mania

When a deactivate transaction reports an error in its send outcome, LookupTableRc::deactivate now returns that transaction error. This keeps the table in its retryable state so the existing background cleanup loop can attempt deactivation again later.

Summary by CodeRabbit

  • Bug Fixes
    • Improved error handling during lookup table deactivation to immediately report transaction failures instead of proceeding with local state changes.

@coderabbitai

coderabbitai Bot commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 59e764ca-a0ea-49fe-92f1-1c4a300cdb7f

📥 Commits

Reviewing files that changed from the base of the PR and between a76aa3b and 4e6bdda.

📒 Files selected for processing (1)
  • magicblock-table-mania/src/lookup_table_rc.rs

📝 Walkthrough

Walkthrough

In LookupTableRc::deactivate, the error handling after send_transaction is updated to return early with MagicBlockRpcClientError::SentTransactionError (wrapping the RPC error and captured signature) when the transaction send fails. Previously, the failure was only logged and execution continued, allowing the local table state to be marked as deactivated despite the on-chain transaction not being confirmed. The fix prevents that erroneous local state transition.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch thlorenz/tablemania-deactivate-error-handling

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant