You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Ensure lookup table deactivation failures are returned to the caller instead of being treated as a successful local state transition.
Details
magicblock-table-mania
When a deactivate transaction reports an error in its send outcome, LookupTableRc::deactivate now returns that transaction error. This keeps the table in its retryable state so the existing background cleanup loop can attempt deactivation again later.
Summary by CodeRabbit
Bug Fixes
Improved error handling during lookup table deactivation to immediately report transaction failures instead of proceeding with local state changes.
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 59e764ca-a0ea-49fe-92f1-1c4a300cdb7f
📥 Commits
Reviewing files that changed from the base of the PR and between a76aa3b and 4e6bdda.
📒 Files selected for processing (1)
magicblock-table-mania/src/lookup_table_rc.rs
📝 Walkthrough
Walkthrough
In LookupTableRc::deactivate, the error handling after send_transaction is updated to return early with MagicBlockRpcClientError::SentTransactionError (wrapping the RPC error and captured signature) when the transaction send fails. Previously, the failure was only logged and execution continued, allowing the local table state to be marked as deactivated despite the on-chain transaction not being confirmed. The fix prevents that erroneous local state transition.
✨ Finishing Touches🧪 Generate unit tests (beta)
Create PR with unit tests
Commit unit tests in branch thlorenz/tablemania-deactivate-error-handling
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ensure lookup table deactivation failures are returned to the caller instead of being treated as a successful local state transition.
Details
magicblock-table-mania
When a deactivate transaction reports an error in its send outcome,
LookupTableRc::deactivatenow returns that transaction error. This keeps the table in its retryable state so the existing background cleanup loop can attempt deactivation again later.Summary by CodeRabbit