Skip to content

feat: add Longan Pi3H #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
meteyou wants to merge 5 commits into
base: master
Choose a base branch
from
Open

feat: add Longan Pi3H #76

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7822365
feat: add Longan Pi3H
meteyou Mar 13, 2026
3d12ad6
fix: add Armbian branch v25.05 for Longan Pi3H configuration to use o…
meteyou Mar 13, 2026
49d80e5
fix: update Longan Pi3H configuration to use Bookworm release
meteyou Mar 13, 2026
e84b2d7
fix: downgrade Armbian branch for Longan Pi3H configuration to v25.02
meteyou Mar 13, 2026
84f6b2d
fix: downgrade Armbian branch for Longan Pi3H configuration to v24.11
meteyou Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions configs/board-longan_pi3h_bookworm.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
BOARD=longanpi-3h
RELEASE="bookworm"
ARMBIAN_BRANCH="v25.05"

@coderabbitai coderabbitai Bot Mar 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

cfg="$(fd 'board-longan_pi3h_bookworm.conf' | head -n1)"
board="$(sed -nE 's/^BOARD="?([^"]+)"?$/\1/p' "$cfg")"
branch="$(sed -nE 's/^ARMBIAN_BRANCH="?([^"]+)"?$/\1/p' "$cfg")"

echo "Config file: $cfg"
echo "BOARD=$board"
echo "ARMBIAN_BRANCH=$branch"

# Expected: tag exists
git ls-remote --exit-code --tags https://github.com/armbian/build.git "refs/tags/$branch" >/dev/null
echo "OK: tag '$branch' exists in armbian/build"

# Expected: at least one board config path contains the board id
python - "$branch" "$board" <<'PY'
import json, sys, urllib.request
branch, board = sys.argv[1], sys.argv[2]
url = f"https://api.github.com/repos/armbian/build/git/trees/{branch}?recursive=1"
with urllib.request.urlopen(url) as r:
    data = json.load(r)
paths = [n.get("path","") for n in data.get("tree",[])]
matches = [p for p in paths if p.startswith("config/boards/") and board.lower() in p.lower()]
if not matches:
    print(f"FAIL: no board config containing '{board}' found under config/boards at {branch}")
    sys.exit(1)
print("OK: matching board config path(s):")
for m in matches[:10]:
    print(" -", m)
PY

Repository: mainsail-crew/armbian-builds

Length of output: 164

🏁 Script executed:

#!/bin/bash
# Check tag existence separately
echo "=== Checking if tag v25.05 exists in armbian/build ==="
git ls-remote --tags https://github.com/armbian/build.git 2>&1 | grep -E 'v25\.05|^fatal|^error' || echo "No match found or connection issue"

echo -e "\n=== Checking available tags near v25.05 ==="
git ls-remote --tags https://github.com/armbian/build.git 2>&1 | grep -E 'v25\.' | tail -20 || echo "Could not fetch tags"

Repository: mainsail-crew/armbian-builds

Length of output: 1552

🏁 Script executed:

#!/bin/bash
# Alternative: check the GitHub API directly for tag v25.05
python3 <<'PYEOF'
import json
import urllib.request
import urllib.error

try:
    # Check if the tag exists via GitHub API
    url = "https://api.github.com/repos/armbian/build/git/ref/tags/v25.05"
    req = urllib.request.Request(url)
    with urllib.request.urlopen(req) as response:
        data = json.load(response)
        print("Tag v25.05 EXISTS")
        print(f"SHA: {data.get('object', {}).get('sha', 'N/A')}")
except urllib.error.HTTPError as e:
    if e.code == 404:
        print("ERROR: Tag v25.05 NOT FOUND in armbian/build")
    else:
        print(f"HTTP Error {e.code}: {e.reason}")
except Exception as e:
    print(f"Error checking tag: {e}")
PYEOF

Repository: mainsail-crew/armbian-builds

Length of output: 219

Replace invalid ARMBIAN_BRANCH="v25.05" with a valid upstream tag.

The tag v25.05 does not exist in the armbian/build repository. Valid tags in the v25 series include v25.5.1, v25.8.0-trunk.*, v25.8.1, and v25.8.2. Choose an appropriate release tag before merge to prevent build failures.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@configs/board-longan_pi3h_bookworm.conf` around lines 1 - 3, The
ARMBIAN_BRANCH value is invalid; update the ARMBIAN_BRANCH variable in the
config (look for the ARMBIAN_BRANCH="v25.05" line in the file) to a valid
upstream tag such as "v25.5.1", "v25.8.1", or "v25.8.2" (choose the appropriate
release for your build), ensuring the string exactly matches an existing tag in
the armbian/build repo so the build can find the correct upstream sources.

Loading