-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Restore sidebar workspace icon size #4973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
austinywang
wants to merge
21
commits into
main
Choose a base branch
from
fix-sidebar-icons-restore-size
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
33c15bc
fix: restore sidebar workspace icon size
austinywang d38650b
fix: guard sidebar icon row metrics
austinywang 2f91595
fix: clarify sidebar icon metric invariant
austinywang abdd78a
test: expect shared sidebar chrome icon metrics
austinywang 8865058
fix: restore sidebar chrome icon size
austinywang 0f6cd6b
test: restore release titlebar icon metrics
austinywang aaddc23
fix: restore release titlebar icon scale
austinywang 99dab20
fix: restore release sidebar toggle symbol
austinywang 7dc55c5
test: require titlebar controls to fit sidebar
austinywang 984a12f
fix: fit release-size titlebar controls in sidebar
austinywang a51ce49
test: require sidebar-width titlebar spacing
austinywang 73a618c
fix: fill sidebar titlebar lane with release spacing
austinywang c8afb1c
fix: return computed titlebar control size
austinywang fb661ee
test: keep sidebar titlebar chrome to release slots
austinywang 80d3e91
fix: keep focus history out of sidebar chrome
austinywang 5e1a5ed
fix: use release slots in titlebar accessory
austinywang 696c750
fix: derive sidebar titlebar slot count
austinywang 7d6a391
fix: reserve sidebar titlebar hint space
austinywang 8dc7bbd
fix: constrain sidebar titlebar chrome styles
austinywang b7ceab1
fix: avoid crashing on sidebar icon padding mismatch
austinywang 13ee964
merge: resolve conflicts with main
austinywang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.