Skip to content

Fix Browser DevTools host reconciliation #4980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lawrencecchen wants to merge 7 commits into
base: main
Choose a base branch
from
+449 −62
Open

Fix Browser DevTools host reconciliation #4980

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
415e685
test: cover browser devtools host regressions
lawrencecchen May 29, 2026
39b9364
fix: reconcile browser devtools host updates
lawrencecchen May 29, 2026
3041e8f
fix: keep forced devtools refresh during transitions
lawrencecchen May 29, 2026
1bdb357
fix: treat stable devtools host hides as close intent
lawrencecchen May 29, 2026
e69e902
test: cover pending devtools open during host churn
lawrencecchen May 29, 2026
c222554
fix: centralize browser devtools lifecycle intent
lawrencecchen May 29, 2026
f23fc90
fix: scope detached devtools windows to owner
lawrencecchen May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Sources/AppDelegate.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15540,8 +15540,7 @@ private extension AppDelegate {
target: target,
sender: sender,
allowFallback: Self.allowsWindowFallback(for: action)
),
BrowserPanel.isDetachedInspectorWindow(window) else { return false }
) else { return false }

for panel in allBrowserPanelsForInspectorWindowClose() {
if panel.closeDeveloperToolsFromDetachedInspectorWindowUserAction(
Expand Down
Loading
Loading