Skip to content

Fix spurious "Terminal needs approval" from Hermes pre_tool_call (#4985) #5010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
austinywang merged 5 commits into from
May 30, 2026

Make Hermes feed-event regression test compile and run; address revie…

6d59f63
Select commit
Loading
Failed to load commit list.
Merged

Fix spurious "Terminal needs approval" from Hermes pre_tool_call (#4985) #5010

Make Hermes feed-event regression test compile and run; address revie…
6d59f63
Select commit
Loading
Failed to load commit list.
Cursor / Cursor Bugbot succeeded May 30, 2026 in 1m 12s

Bugbot Review

Bugbot Analysis Progress (1m 15s elapsed)

✅ Gathered PR context (3s)
✅ Completed bug detection (1m 11s)
✅ Posted analysis results (1s)

Final Result: Bugbot completed review - no issues found! ✅

Request ID: serverGenReqId_48a982cd-4ad6-47e2-9b3c-18320a023bb5

Details

View more details on Cursor