Skip to content

Add "Send Ctrl-F to Terminal" passthrough action (force-stop Claude Code agents) (#4993) #5011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
austinywang merged 2 commits into from
Jun 1, 2026
Merged

Add "Send Ctrl-F to Terminal" passthrough action (force-stop Claude Code agents) (#4993) #5011

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11b89ef
Add "Send Ctrl-F to Terminal" passthrough action (force-stop CC agents)
austinywang May 30, 2026
fb798df
Localize Ctrl-F passthrough strings for all catalog locales
austinywang May 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
375 changes: 375 additions & 0 deletions Resources/Localizable.xcstrings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155872,6 +155872,381 @@
}
}
},
"command.terminalSendCtrlF.title": {
"extractionState": "manual",
"localizations": {
"ar": {
"stringUnit": {
"state": "needs_review",
"value": "Send Ctrl-F to Terminal"
}
},
"bs": {
"stringUnit": {
"state": "needs_review",
"value": "Send Ctrl-F to Terminal"
}
},
"da": {
"stringUnit": {
"state": "needs_review",
"value": "Send Ctrl-F to Terminal"
}
},
"de": {
"stringUnit": {
"state": "needs_review",
"value": "Send Ctrl-F to Terminal"
}
},
"en": {
"stringUnit": {
"state": "translated",
"value": "Send Ctrl-F to Terminal"
}
},
"es": {
"stringUnit": {
"state": "needs_review",
"value": "Send Ctrl-F to Terminal"
}
},
"fr": {
"stringUnit": {
"state": "needs_review",
"value": "Send Ctrl-F to Terminal"
}
},
"it": {
"stringUnit": {
"state": "needs_review",
"value": "Send Ctrl-F to Terminal"
}
},
"ja": {
"stringUnit": {
"state": "translated",
Comment on lines 155872 to 156252
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot May 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Missing locale entries for 18 locales

The three new string keys (command.terminalSendCtrlF.title, menu.find.sendCtrlFToTerminal, shortcut.sendCtrlFToTerminal.label) only include en and ja localizations. The catalog already supports ar, bs, da, de, es, fr, it, km, ko, nb, pl, pt-BR, ru, th, tr, uk, zh-Hans, and zh-Hant. Every other entry added alongside a new action (e.g. shortcut.attachTextBoxFile.label) carries "state": "needs_review" stubs for every supported locale. Without those stubs, the string catalog is incomplete and users on non-en/non-ja builds will fall back to the defaultValue literal rather than a catalog-managed fallback — bypassing translation pipeline review for all 18 locales.

Rule Used: Flag production user-facing text that is not fully... (source)

Copy link
Copy Markdown
Contributor Author

@austinywang austinywang May 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in fb798df — expanded all three new keys to the full 20-locale catalog set (en + ja translated; the other 18 locales seeded with the English value and state=needs_review, matching the placeholder convention existing untranslated entries use).

— Claude Code

"value": "ターミナルにCtrl-Fを送信"
}
},
"km": {
"stringUnit": {
"state": "needs_review",
"value": "Send Ctrl-F to Terminal"
}
},
"ko": {
"stringUnit": {
"state": "needs_review",
"value": "Send Ctrl-F to Terminal"
}
},
"nb": {
"stringUnit": {
"state": "needs_review",
"value": "Send Ctrl-F to Terminal"
}
},
"pl": {
"stringUnit": {
"state": "needs_review",
"value": "Send Ctrl-F to Terminal"
}
},
"pt-BR": {
"stringUnit": {
"state": "needs_review",
"value": "Send Ctrl-F to Terminal"
}
},
"ru": {
"stringUnit": {
"state": "needs_review",
"value": "Send Ctrl-F to Terminal"
}
},
"th": {
"stringUnit": {
"state": "needs_review",
"value": "Send Ctrl-F to Terminal"
}
},
"tr": {
"stringUnit": {
"state": "needs_review",
"value": "Send Ctrl-F to Terminal"
}
},
"uk": {
"stringUnit": {
"state": "needs_review",
"value": "Send Ctrl-F to Terminal"
}
},
"zh-Hans": {
"stringUnit": {
"state": "needs_review",
"value": "Send Ctrl-F to Terminal"
}
},
"zh-Hant": {
"stringUnit": {
"state": "needs_review",
"value": "Send Ctrl-F to Terminal"
}
}
}
},
"menu.find.sendCtrlFToTerminal": {
"extractionState": "manual",
"localizations": {
"ar": {
"stringUnit": {
"state": "needs_review",
"value": "Send Ctrl-F to Terminal"
}
},
"bs": {
"stringUnit": {
"state": "needs_review",
"value": "Send Ctrl-F to Terminal"
}
},
"da": {
"stringUnit": {
"state": "needs_review",
"value": "Send Ctrl-F to Terminal"
}
},
"de": {
"stringUnit": {
"state": "needs_review",
"value": "Send Ctrl-F to Terminal"
}
},
"en": {
"stringUnit": {
"state": "translated",
"value": "Send Ctrl-F to Terminal"
}
},
"es": {
"stringUnit": {
"state": "needs_review",
"value": "Send Ctrl-F to Terminal"
}
},
"fr": {
"stringUnit": {
"state": "needs_review",
"value": "Send Ctrl-F to Terminal"
}
},
"it": {
"stringUnit": {
"state": "needs_review",
"value": "Send Ctrl-F to Terminal"
}
},
"ja": {
"stringUnit": {
"state": "translated",
"value": "ターミナルにCtrl-Fを送信"
}
},
"km": {
"stringUnit": {
"state": "needs_review",
"value": "Send Ctrl-F to Terminal"
}
},
"ko": {
"stringUnit": {
"state": "needs_review",
"value": "Send Ctrl-F to Terminal"
}
},
"nb": {
"stringUnit": {
"state": "needs_review",
"value": "Send Ctrl-F to Terminal"
}
},
"pl": {
"stringUnit": {
"state": "needs_review",
"value": "Send Ctrl-F to Terminal"
}
},
"pt-BR": {
"stringUnit": {
"state": "needs_review",
"value": "Send Ctrl-F to Terminal"
}
},
"ru": {
"stringUnit": {
"state": "needs_review",
"value": "Send Ctrl-F to Terminal"
}
},
"th": {
"stringUnit": {
"state": "needs_review",
"value": "Send Ctrl-F to Terminal"
}
},
"tr": {
"stringUnit": {
"state": "needs_review",
"value": "Send Ctrl-F to Terminal"
}
},
"uk": {
"stringUnit": {
"state": "needs_review",
"value": "Send Ctrl-F to Terminal"
}
},
"zh-Hans": {
"stringUnit": {
"state": "needs_review",
"value": "Send Ctrl-F to Terminal"
}
},
"zh-Hant": {
"stringUnit": {
"state": "needs_review",
"value": "Send Ctrl-F to Terminal"
}
}
}
},
"shortcut.sendCtrlFToTerminal.label": {
"extractionState": "manual",
"localizations": {
"ar": {
"stringUnit": {
"state": "needs_review",
"value": "Send Ctrl-F to Terminal"
}
},
"bs": {
"stringUnit": {
"state": "needs_review",
"value": "Send Ctrl-F to Terminal"
}
},
"da": {
"stringUnit": {
"state": "needs_review",
"value": "Send Ctrl-F to Terminal"
}
},
"de": {
"stringUnit": {
"state": "needs_review",
"value": "Send Ctrl-F to Terminal"
}
},
"en": {
"stringUnit": {
"state": "translated",
"value": "Send Ctrl-F to Terminal"
}
},
"es": {
"stringUnit": {
"state": "needs_review",
"value": "Send Ctrl-F to Terminal"
}
},
"fr": {
"stringUnit": {
"state": "needs_review",
"value": "Send Ctrl-F to Terminal"
}
},
"it": {
"stringUnit": {
"state": "needs_review",
"value": "Send Ctrl-F to Terminal"
}
},
"ja": {
"stringUnit": {
"state": "translated",
"value": "ターミナルにCtrl-Fを送信"
}
},
"km": {
"stringUnit": {
"state": "needs_review",
"value": "Send Ctrl-F to Terminal"
}
},
"ko": {
"stringUnit": {
"state": "needs_review",
"value": "Send Ctrl-F to Terminal"
}
},
"nb": {
"stringUnit": {
"state": "needs_review",
"value": "Send Ctrl-F to Terminal"
}
},
"pl": {
"stringUnit": {
"state": "needs_review",
"value": "Send Ctrl-F to Terminal"
}
},
"pt-BR": {
"stringUnit": {
"state": "needs_review",
"value": "Send Ctrl-F to Terminal"
}
},
"ru": {
"stringUnit": {
"state": "needs_review",
"value": "Send Ctrl-F to Terminal"
}
},
"th": {
"stringUnit": {
"state": "needs_review",
"value": "Send Ctrl-F to Terminal"
}
},
"tr": {
"stringUnit": {
"state": "needs_review",
"value": "Send Ctrl-F to Terminal"
}
},
"uk": {
"stringUnit": {
"state": "needs_review",
"value": "Send Ctrl-F to Terminal"
}
},
"zh-Hans": {
"stringUnit": {
"state": "needs_review",
"value": "Send Ctrl-F to Terminal"
}
},
"zh-Hant": {
"stringUnit": {
"state": "needs_review",
"value": "Send Ctrl-F to Terminal"
}
}
}
},
"shortcut.attachTextBoxFile.label": {
"extractionState": "manual",
"localizations": {
Expand Down
Loading
Loading