Widen font-size bounds + add Terminal Font Size setting #5338
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -115203,6 +115203,23 @@ | |
| } | ||
| } | ||
| }, | ||
| "settings.search.alias.setting.terminal.font-size": { | ||
| "extractionState": "manual", | ||
| "localizations": { | ||
| "en": { | ||
| "stringUnit": { | ||
| "state": "translated", | ||
| "value": "font-size terminal font size text scale shell zoom bigger smaller larger point base" | ||
| } | ||
| }, | ||
| "ja": { | ||
| "stringUnit": { | ||
| "state": "translated", | ||
| "value": "font-size terminal font size ターミナル フォントサイズ テキスト 拡大 縮小 ズーム 大きく 小さく ポイント" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "settings.search.alias.setting.terminal.tab-bar-font-size": { | ||
| "extractionState": "manual", | ||
| "localizations": { | ||
|
Comment on lines
115203
to
115225
Contributor
There was a problem hiding this comment.
The catalog contains 21 locales (ar, bs, da, de, en, es, fr, it, ja, km, ko, nb, ok, pl, pt, pt-BR, px, ru, th, tr, uk), but all five new keys ( Rule Used: Flag production user-facing text that is not fully... (source) |
||
|
|
@@ -145899,6 +145916,74 @@ | |
| } | ||
| } | ||
| }, | ||
| "settings.terminal.fontSize": { | ||
| "extractionState": "manual", | ||
| "localizations": { | ||
| "en": { | ||
| "stringUnit": { | ||
| "state": "translated", | ||
| "value": "Terminal Font Size" | ||
| } | ||
| }, | ||
| "ja": { | ||
| "stringUnit": { | ||
| "state": "translated", | ||
| "value": "ターミナルのフォントサイズ" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "settings.terminal.fontSize.reset": { | ||
| "extractionState": "manual", | ||
| "localizations": { | ||
| "en": { | ||
| "stringUnit": { | ||
| "state": "translated", | ||
| "value": "Reset" | ||
| } | ||
| }, | ||
| "ja": { | ||
| "stringUnit": { | ||
| "state": "translated", | ||
| "value": "リセット" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "settings.terminal.fontSize.saveFailed": { | ||
| "extractionState": "manual", | ||
| "localizations": { | ||
| "en": { | ||
| "stringUnit": { | ||
| "state": "translated", | ||
| "value": "Couldn't save terminal font size. Please try again." | ||
| } | ||
| }, | ||
| "ja": { | ||
| "stringUnit": { | ||
| "state": "translated", | ||
| "value": "ターミナルのフォントサイズを保存できませんでした。もう一度お試しください。" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "settings.terminal.fontSize.subtitle": { | ||
| "extractionState": "manual", | ||
| "localizations": { | ||
| "en": { | ||
| "stringUnit": { | ||
| "state": "translated", | ||
| "value": "Sets the base font size of terminal text. The Cmd +/- zoom shortcut adjusts the live size on top of this." | ||
| } | ||
| }, | ||
| "ja": { | ||
| "stringUnit": { | ||
| "state": "translated", | ||
| "value": "ターミナルテキストの基本フォントサイズを設定します。Cmd +/- のズームショートカットは、これに加えて表示サイズを調整します。" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "settings.terminal.tabBarFontSize": { | ||
| "extractionState": "manual", | ||
| "localizations": { | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -19,9 +19,12 @@ struct GhosttyConfig { | |||||
| static let defaultSurfaceTabBarFontSize = CGFloat(CmuxGhosttyConfigSettingEditor.defaultSurfaceTabBarFontSize) | ||||||
| static let minSurfaceTabBarFontSize = CGFloat(CmuxGhosttyConfigSettingEditor.minSurfaceTabBarFontSize) | ||||||
| static let maxSurfaceTabBarFontSize = CGFloat(CmuxGhosttyConfigSettingEditor.maxSurfaceTabBarFontSize) | ||||||
| static let defaultTerminalFontSize = CGFloat(CmuxGhosttyConfigSettingEditor.defaultTerminalFontSize) | ||||||
| static let minTerminalFontSize = CGFloat(CmuxGhosttyConfigSettingEditor.minTerminalFontSize) | ||||||
| static let maxTerminalFontSize = CGFloat(CmuxGhosttyConfigSettingEditor.maxTerminalFontSize) | ||||||
|
|
||||||
| var fontFamily: String = "Menlo" | ||||||
| var fontSize: CGFloat = Self.defaultTerminalFontSize | ||||||
| var surfaceTabBarFontSize: CGFloat = Self.defaultSurfaceTabBarFontSize | ||||||
| var sidebarFontSize: CGFloat = Self.defaultSidebarFontSize | ||||||
| var theme: String? | ||||||
|
|
@@ -401,8 +404,8 @@ struct GhosttyConfig { | |||||
| case "font-family": | ||||||
| fontFamily = value | ||||||
| case "font-size": | ||||||
| if let size = Double(value), size.isFinite { | ||||||
| fontSize = Self.clampedTerminalFontSize(CGFloat(size)) | ||||||
|
Comment on lines
+407
to
+408
There was a problem hiding this comment.
When users already have a Ghostty Useful? React with 👍 / 👎. There was a problem hiding this comment. Clamped parse desyncs terminal UILow Severity Parsing Additional Locations (1)  Reviewed by Cursor Bugbot for commit 40b5716. Configure here. There was a problem hiding this comment. P2: Parse-time clamping of Prompt for AI agents
Suggested change
|
||||||
| } | ||||||
| case "surface-tab-bar-font-size": | ||||||
| if let size = Double(value), size.isFinite { | ||||||
|
|
@@ -681,6 +684,10 @@ struct GhosttyConfig { | |||||
| CGFloat(CmuxGhosttyConfigSettingEditor.clampedSurfaceTabBarFontSize(Double(value))) | ||||||
| } | ||||||
|
|
||||||
| static func clampedTerminalFontSize(_ value: CGFloat) -> CGFloat { | ||||||
| CGFloat(CmuxGhosttyConfigSettingEditor.clampedTerminalFontSize(Double(value))) | ||||||
| } | ||||||
|
|
||||||
| private static func parseBackgroundBlur(_ value: String) -> GhosttyBackgroundBlur? { | ||||||
| switch value { | ||||||
| case "false", "0": | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The shipped Settings window builds its sidebar search from
CmuxSettingsUI.SettingsSearchIndex/CuratedSettingEntry+Default, not the legacySources/SettingsNavigationtable updated in this commit; because this new.settingsOnlyrow also has no explicitsearchAnchorID, searching for terminal font size cannot surface or scroll/highlight this row in the active settings UI. Add the entry to the package search index and give this settings-only row the matching anchor so the new setting is discoverable.Useful? React with 👍 / 👎.