Fix TextBox unchanged binding writes #5345
+123
−6
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| import AppKit | ||
| import SwiftUI | ||
| import Testing | ||
|
|
||
| #if canImport(cmux_DEV) | ||
| @testable import cmux_DEV | ||
| #elseif canImport(cmux) | ||
| @testable import cmux | ||
| #endif | ||
|
|
||
| @MainActor | ||
| struct TextBoxContentSyncTests { | ||
| @Test func contentSyncSkipsUnchangedSwiftUIBindings() { | ||
| var text = "same" | ||
| var attachments: [TextBoxAttachment] = [] | ||
| var height: CGFloat = 24 | ||
| var hasPendingAttachmentUpload = false | ||
| var textWriteCount = 0 | ||
| var attachmentWriteCount = 0 | ||
| var pendingWriteCount = 0 | ||
| var contentChangeCount = 0 | ||
|
|
||
| let inputView = TextBoxInputView( | ||
| text: Binding( | ||
| get: { text }, | ||
| set: { newValue in | ||
| textWriteCount += 1 | ||
| text = newValue | ||
| } | ||
| ), | ||
| attachments: Binding( | ||
| get: { attachments }, | ||
| set: { newValue in | ||
| attachmentWriteCount += 1 | ||
| attachments = newValue | ||
| } | ||
| ), | ||
| textViewHeight: Binding(get: { height }, set: { height = $0 }), | ||
|
There was a problem hiding this comment. 🧹 Nitpick | 🔵 Trivial | 💤 Low value Consider tracking The sibling test ( var heightWriteCount = 0
// ...
textViewHeight: Binding(
get: { height },
set: { newValue in
heightWriteCount += 1
height = newValue
}
),
// ...
`#expect`(heightWriteCount == 0)If height is intentionally excluded because it's layout-derived rather than content-derived, a brief comment explaining that would clarify the test's scope. 🤖 Prompt for AI Agents |
||
| hasPendingAttachmentUpload: Binding( | ||
| get: { hasPendingAttachmentUpload }, | ||
| set: { newValue in | ||
| pendingWriteCount += 1 | ||
| hasPendingAttachmentUpload = newValue | ||
| } | ||
| ), | ||
| font: NSFont.systemFont(ofSize: 14), | ||
| backgroundColor: .textBackgroundColor, | ||
| foregroundColor: .labelColor, | ||
| terminalTitle: "codex", | ||
| completionRootDirectory: nil, | ||
| onSubmit: {}, | ||
| onEscape: {}, | ||
| onFocusTextBox: {}, | ||
| onToggleFocus: {}, | ||
| onForwardText: { _, _ in }, | ||
| onForwardKey: { _ in }, | ||
| onForwardControl: { _ in }, | ||
| onPaste: { _, _ in false }, | ||
| onInsertFileURLs: { _, _ in false }, | ||
| onChooseFiles: {}, | ||
| onContentChanged: { contentChangeCount += 1 }, | ||
| onTextViewCreated: { _ in }, | ||
| onTextViewMovedToWindow: { _ in }, | ||
| onTextViewDismantled: { _ in } | ||
| ) | ||
| let coordinator = TextBoxInputView.Coordinator(parent: inputView) | ||
| let textView = TextBoxInputTextView(frame: NSRect(x: 0, y: 0, width: 320, height: 30)) | ||
| textView.font = NSFont.systemFont(ofSize: 14) | ||
| textView.textColor = .labelColor | ||
| textView.string = "same" | ||
|
|
||
| coordinator.textDidChange(Notification(name: NSText.didChangeNotification, object: textView)) | ||
|
|
||
| #expect(textWriteCount == 0) | ||
| #expect(attachmentWriteCount == 0) | ||
| #expect(pendingWriteCount == 0) | ||
| #expect(contentChangeCount == 0) | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: manaflow-ai/cmux
Length of output: 1295
Fix regression commit ordering for the TextBox unchanged-binding write bug.
cmuxTests/TextBoxContentSyncTests.swift(added in commita64519f3) is introduced after the production change (fix: skip unchanged TextBox binding writes, commite200cae7), so the required failing-test-only commit step (CI red) → fix commit step (CI green) isn’t present.🤖 Prompt for AI Agents