-
Notifications
You must be signed in to change notification settings - Fork 13
chore: retains apiversion in app description and app deployments #189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: pre-draft
Are you sure you want to change the base?
Changes from 2 commits
44d4de5
4791c7c
625e7a0
be0a2bc
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| # Demonstrates validation of spec.applicationId | ||
| # Invalid characters being used. | ||
| apiVersion: application.margo.org/v1alpha1 | ||
| apiVersion: 1.0.0 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should be v1.0.0-rc.2 |
||
| kind: ApplicationDeployment | ||
| id: a3e2f5dc-912e-494f-8395-52cf3769bc06 | ||
| metadata: | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| # Demonstrates validation of spec.applicationId | ||
| # Too long. | ||
| apiVersion: application.margo.org/v1alpha1 | ||
| apiVersion: 1.0.0 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should be v1.0.0-rc.2 |
||
| kind: ApplicationDeployment | ||
| id: a3e2f5dc-912e-494f-8395-52cf3769bc06 | ||
| metadata: | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| # Demonstrates validation of id field | ||
| # Not a valid UUID. | ||
| apiVersion: application.margo.org/v1alpha1 | ||
| apiVersion: 1.0.0 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should be v1.0.0-rc.2 |
||
| kind: ApplicationDeployment | ||
| # id is not a valid UUID | ||
| id: this-is-definitively-not-a-uuid | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.